[jira] [Commented] (OFBIZ-12278) Link request-confirmation not generated on menus

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378235#comment-17378235 ] 

ASF subversion and git services commented on OFBIZ-12278:
---------------------------------------------------------

Commit 894408cb0d9a6f08009ff3a90ea8a92f25fabd42 in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=894408c ]

Fixed: Link request-confirmation not generated on menus (OFBIZ-12278)

Menus link with request-confirmation and confirmation message do not generate the script that open confirmation

When you activate the following menu item :
      <menu-item name="statusToCancelled" title="${uiLabelMap.AccountingPaymentTabStatusToCancelled}">
          <link target="setPaymentStatus" request-confirmation="true" confirmation-message="You want to cancel this payment number ${payment.paymentId}?">
              ....
         </link>
      </menu-item>

OFBiz to not generate the js code link to the request-confirmation attribute because this functionality has been never implemented on java code for MenuRenderer

Thanks to Leila Mekika for raised this issue and solved it


> Link request-confirmation not generated on menus
> ------------------------------------------------
>
>                 Key: OFBIZ-12278
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12278
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk, 17.12.07
>            Reporter: Leila Mekika
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: OFBIZ-12278.patch
>
>
> Menus link with request-confirmation and confirmation message do not generate the script that open confirmation
> To reproduce, you can check the link "Status to cancelled" on a created payment who does not ask for confirmation while his definition is done:
> {code:java}
> <link target="setPaymentStatus" request-confirmation="true" confirmation-message="You want to cancel this payment number ${payment.paymentId}?">
>  <parameter param-name="paymentId" from-field="payment.paymentId"/>
>  <parameter param-name="statusId" value="PMNT_CANCELLED"/>
>  </link>
> {code}
> ex: 
>  [https://demo-stable.ofbiz.apache.org/accounting/control/paymentOverview?paymentId=9000]
> [https://demo-trunk.ofbiz.apache.org/accounting/control/paymentOverview?paymentId=9000]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)