[GitHub] [apisix] bisakhmondal commented on a change in pull request #6241: refactor: mv the var mqtt_client_id to plugin level

[GitBox <gi...@apache.org>]

bisakhmondal commented on a change in pull request #6241:
URL: https://github.com/apache/apisix/pull/6241#discussion_r797825041



##########
File path: apisix/core/ctx.lua
##########
@@ -254,10 +253,6 @@ function _M.register_var(name, getter)
         error("the getter of registered var should be a function")
     end
 
-    if apisix_var_names[name] then
-        error(name .. " is registered")
-    end
-

Review comment:
       I think we can keep it. This can act as a protection to prevent overriding defaults / name conflict.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org