You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by David Blevins <da...@gmail.com> on 2018/10/01 18:51:52 UTC
Re: xbean-reflect changes and potential xbean 5?
> On Aug 8, 2018, at 6:53 PM, David Blevins <da...@gmail.com> wrote:
>
> I'd love to do a 4.x release of this code.
Hey Romain, is there any reason you pulled this code out of the XBean 4.10 release? Ideally we discuss these things as a community before tacking action.
Would you mind if I did a 4.11 with it included?
-David
Re: xbean-reflect changes and potential xbean 5?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Thanks David.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le mar. 2 oct. 2018 à 18:23, David Blevins <da...@gmail.com> a
écrit :
> I think what threw me off was seeing XBEAN-309 updated from 4.10 to 4.11.
> I suspect you moved it only because I hadn't bother to close it, which I
> should.
>
> I've updated it to 4.10 and marked it closed.
>
> -David
>
> > On Oct 2, 2018, at 12:27 AM, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
> >
> > No worries, let's tackle this asm7 thing and we can even add other
> features ;)
> >
> > Romain Manni-Bucau
> > @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book
> >
> >
> > Le mar. 2 oct. 2018 à 00:01, David Blevins <da...@gmail.com> a
> écrit :
> > Apparently I have to worry about becoming senile. I did an svn log and
> swore I didn't see the commit in there. It's definitely there. I think my
> mind has been warped by working with Git too long.
> >
> > Sorry for the noise and thank for the release, sir!
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> > > On Oct 1, 2018, at 1:10 PM, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
> > >
> > > Seems the code is still here - see
> https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
> > >
> > > Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau <rm...@gmail.com>
> a écrit :
> > > Hmm, thought i just did what was mentionned in this thread which was
> not about dropping any code but ensuring static usage was kept only for
> compatibility and moving to a not leaking impl.
> > >
> > > Do you have a failling test of the missing feature? - feel free to
> push it with @Ignore ;). I can check tomorrow I think.
> > >
> > > We will release soon the 4.11 with asm7 support - we just need to
> finish to decide if there is a blocker to do asm7 package or not (another
> thread on it).
> > >
> > > Le lun. 1 oct. 2018 20:52, David Blevins <da...@gmail.com> a
> écrit :
> > > > On Aug 8, 2018, at 6:53 PM, David Blevins <da...@gmail.com>
> wrote:
> > > >
> > > > I'd love to do a 4.x release of this code.
> > >
> > > Hey Romain, is there any reason you pulled this code out of the XBean
> 4.10 release? Ideally we discuss these things as a community before
> tacking action.
> > >
> > > Would you mind if I did a 4.11 with it included?
> > >
> > >
> > >
> > > -David
> > >
> > >
> >
>
>
Re: xbean-reflect changes and potential xbean 5?
Posted by David Blevins <da...@gmail.com>.
I think what threw me off was seeing XBEAN-309 updated from 4.10 to 4.11. I suspect you moved it only because I hadn't bother to close it, which I should.
I've updated it to 4.10 and marked it closed.
-David
> On Oct 2, 2018, at 12:27 AM, Romain Manni-Bucau <rm...@gmail.com> wrote:
>
> No worries, let's tackle this asm7 thing and we can even add other features ;)
>
> Romain Manni-Bucau
> @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book
>
>
> Le mar. 2 oct. 2018 à 00:01, David Blevins <da...@gmail.com> a écrit :
> Apparently I have to worry about becoming senile. I did an svn log and swore I didn't see the commit in there. It's definitely there. I think my mind has been warped by working with Git too long.
>
> Sorry for the noise and thank for the release, sir!
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Oct 1, 2018, at 1:10 PM, Romain Manni-Bucau <rm...@gmail.com> wrote:
> >
> > Seems the code is still here - see https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
> >
> > Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau <rm...@gmail.com> a écrit :
> > Hmm, thought i just did what was mentionned in this thread which was not about dropping any code but ensuring static usage was kept only for compatibility and moving to a not leaking impl.
> >
> > Do you have a failling test of the missing feature? - feel free to push it with @Ignore ;). I can check tomorrow I think.
> >
> > We will release soon the 4.11 with asm7 support - we just need to finish to decide if there is a blocker to do asm7 package or not (another thread on it).
> >
> > Le lun. 1 oct. 2018 20:52, David Blevins <da...@gmail.com> a écrit :
> > > On Aug 8, 2018, at 6:53 PM, David Blevins <da...@gmail.com> wrote:
> > >
> > > I'd love to do a 4.x release of this code.
> >
> > Hey Romain, is there any reason you pulled this code out of the XBean 4.10 release? Ideally we discuss these things as a community before tacking action.
> >
> > Would you mind if I did a 4.11 with it included?
> >
> >
> >
> > -David
> >
> >
>
Re: xbean-reflect changes and potential xbean 5?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
No worries, let's tackle this asm7 thing and we can even add other features
;)
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le mar. 2 oct. 2018 à 00:01, David Blevins <da...@gmail.com> a
écrit :
> Apparently I have to worry about becoming senile. I did an svn log and
> swore I didn't see the commit in there. It's definitely there. I think my
> mind has been warped by working with Git too long.
>
> Sorry for the noise and thank for the release, sir!
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Oct 1, 2018, at 1:10 PM, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
> >
> > Seems the code is still here - see
> https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
> >
> > Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau <rm...@gmail.com> a
> écrit :
> > Hmm, thought i just did what was mentionned in this thread which was not
> about dropping any code but ensuring static usage was kept only for
> compatibility and moving to a not leaking impl.
> >
> > Do you have a failling test of the missing feature? - feel free to push
> it with @Ignore ;). I can check tomorrow I think.
> >
> > We will release soon the 4.11 with asm7 support - we just need to finish
> to decide if there is a blocker to do asm7 package or not (another thread
> on it).
> >
> > Le lun. 1 oct. 2018 20:52, David Blevins <da...@gmail.com> a
> écrit :
> > > On Aug 8, 2018, at 6:53 PM, David Blevins <da...@gmail.com>
> wrote:
> > >
> > > I'd love to do a 4.x release of this code.
> >
> > Hey Romain, is there any reason you pulled this code out of the XBean
> 4.10 release? Ideally we discuss these things as a community before
> tacking action.
> >
> > Would you mind if I did a 4.11 with it included?
> >
> >
> >
> > -David
> >
> >
>
>
Re: xbean-reflect changes and potential xbean 5?
Posted by David Blevins <da...@gmail.com>.
Apparently I have to worry about becoming senile. I did an svn log and swore I didn't see the commit in there. It's definitely there. I think my mind has been warped by working with Git too long.
Sorry for the noise and thank for the release, sir!
--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com
> On Oct 1, 2018, at 1:10 PM, Romain Manni-Bucau <rm...@gmail.com> wrote:
>
> Seems the code is still here - see https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
>
> Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau <rm...@gmail.com> a écrit :
> Hmm, thought i just did what was mentionned in this thread which was not about dropping any code but ensuring static usage was kept only for compatibility and moving to a not leaking impl.
>
> Do you have a failling test of the missing feature? - feel free to push it with @Ignore ;). I can check tomorrow I think.
>
> We will release soon the 4.11 with asm7 support - we just need to finish to decide if there is a blocker to do asm7 package or not (another thread on it).
>
> Le lun. 1 oct. 2018 20:52, David Blevins <da...@gmail.com> a écrit :
> > On Aug 8, 2018, at 6:53 PM, David Blevins <da...@gmail.com> wrote:
> >
> > I'd love to do a 4.x release of this code.
>
> Hey Romain, is there any reason you pulled this code out of the XBean 4.10 release? Ideally we discuss these things as a community before tacking action.
>
> Would you mind if I did a 4.11 with it included?
>
>
>
> -David
>
>
Re: xbean-reflect changes and potential xbean 5?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Seems the code is still here - see
https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java
Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau <rm...@gmail.com> a
écrit :
> Hmm, thought i just did what was mentionned in this thread which was not
> about dropping any code but ensuring static usage was kept only for
> compatibility and moving to a not leaking impl.
>
> Do you have a failling test of the missing feature? - feel free to push it
> with @Ignore ;). I can check tomorrow I think.
>
> We will release soon the 4.11 with asm7 support - we just need to finish
> to decide if there is a blocker to do asm7 package or not (another thread
> on it).
>
> Le lun. 1 oct. 2018 20:52, David Blevins <da...@gmail.com> a
> écrit :
>
>> > On Aug 8, 2018, at 6:53 PM, David Blevins <da...@gmail.com>
>> wrote:
>> >
>> > I'd love to do a 4.x release of this code.
>>
>> Hey Romain, is there any reason you pulled this code out of the XBean
>> 4.10 release? Ideally we discuss these things as a community before
>> tacking action.
>>
>> Would you mind if I did a 4.11 with it included?
>>
>>
>>
>> -David
>>
>>
>>
Re: xbean-reflect changes and potential xbean 5?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hmm, thought i just did what was mentionned in this thread which was not
about dropping any code but ensuring static usage was kept only for
compatibility and moving to a not leaking impl.
Do you have a failling test of the missing feature? - feel free to push it
with @Ignore ;). I can check tomorrow I think.
We will release soon the 4.11 with asm7 support - we just need to finish to
decide if there is a blocker to do asm7 package or not (another thread on
it).
Le lun. 1 oct. 2018 20:52, David Blevins <da...@gmail.com> a écrit :
> > On Aug 8, 2018, at 6:53 PM, David Blevins <da...@gmail.com>
> wrote:
> >
> > I'd love to do a 4.x release of this code.
>
> Hey Romain, is there any reason you pulled this code out of the XBean 4.10
> release? Ideally we discuss these things as a community before tacking
> action.
>
> Would you mind if I did a 4.11 with it included?
>
>
>
> -David
>
>
>