You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by DimDroll <gi...@git.apache.org> on 2017/09/27 22:41:07 UTC
[GitHub] metron pull request #776: Fix link to RPMs chapter
GitHub user DimDroll opened a pull request:
https://github.com/apache/metron/pull/776
Fix link to RPMs chapter
## Contributor Comments
[Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DimDroll/incubator-metron patch-4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/776.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #776
----
commit 55fb73f8c30ef1ffc6a03513c3d451be20e9af4e
Author: DimDroll <di...@gmail.com>
Date: 2017-09-27T22:40:28Z
Fix link to RPMs chapter
----
---
[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/776
@DimDroll Thanks for creating the Jira. It's a pretty small thing, but it helps keep everything consistent and makes it easy to compile and search on during releases, etc.
---
[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/776
@simonellistonball Is that comment meant for https://github.com/apache/metron/pull/775? I think you're on the wrong PR
---
[GitHub] metron issue #776: Fix link to RPMs chapter
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/776
@DimDroll Can you put the jira number at the front of the PR name like the other PRs have please?
---
[GitHub] metron issue #776: Fix link to RPMs chapter
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/776
+1, was able to see it work in Github's view. Thanks a lot for the fix.
---
[GitHub] metron pull request #776: METRON-1215: Fix link to RPMs chapter
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/776
---
[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter
Posted by DimDroll <gi...@git.apache.org>.
Github user DimDroll commented on the issue:
https://github.com/apache/metron/pull/776
@justinleet, sure, done:
https://issues.apache.org/jira/browse/METRON-1215
I thought for such minor change jira case would be overkill :)
---
[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter
Posted by simonellistonball <gi...@git.apache.org>.
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/776
Do we need to ensure we're picking this from the right repos? We should probably use the nodesource rpm repo rather than relying on the centos build, which is a very very old version, and could cause issues. Adding a the repo file in might be a good call.
---
[GitHub] metron issue #776: METRON-1215: Fix link to RPMs chapter
Posted by simonellistonball <gi...@git.apache.org>.
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/776
Yes, it is, not sure how that happened. Probably too many tabs.
---