[GitHub] [lucene] rmuir commented on pull request #34: LUCENE-9856: fail precommit on unused local variables

[GitBox <gi...@apache.org>]

rmuir commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804474683


   This change is largely mechanical: simply remove the unused local variables. Try to preserve any method calls that may have side effects (e.g. throw exception) in tests.
   
   In general, it is usually a pretty bad smell to have such unused variables: the idea is not to go sniffing around that and debug deeply, but just to get the stuff fixed so the linter can stop new stuff from coming in.
   
   If you want to help fix the issues (or make the gradle better!!!), please, feel free to just push commits to the branch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org