[GitHub] [hudi] yihua commented on a change in pull request #3743: [HUDI-2513] Refactor table upgrade and downgrade actions in hudi-client module

[GitBox <gi...@apache.org>]

yihua commented on a change in pull request #3743:
URL: https://github.com/apache/hudi/pull/3743#discussion_r722935917



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackStrategy.java
##########
@@ -63,7 +63,8 @@ public ListingBasedRollbackStrategy(HoodieTable table,
             table.getMetaClient().getBasePath(), config);
       } else {
         rollbackRequests = RollbackUtils
-            .generateRollbackRequestsUsingFileListingMOR(instantToRollback, table, context);
+            .generateRollbackRequestsUsingFileListingMOR(

Review comment:
       The reason to refactor the rollback methods was to avoid upgrade and downgrade helpers in the engine client package.  As discussed offline, I keep one helper class for engine-specific logic needed for the upgrade and downgrade actions.  Based on that I keep these rollback methods the same now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org