[GitHub] [calcite] amaliujia commented on a change in pull request #2113: [CALCITE-4176] Key descriptor can be optional in SESSION table function (Rui Wang)

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #2113:
URL: https://github.com/apache/calcite/pull/2113#discussion_r472664692



##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -10435,32 +10435,30 @@ private void checkCustomColumnResolving(String table) {
         + "size => interval '1' hour))")
         .fails("Param 'data' not found in function 'SESSION'; did you mean 'DATA'\\?");
     sql("select * from table(\n"
-        + "^session(\n"
+        + "session(\n"
         + "data => table orders,\n"
         + "key => descriptor(productid),\n"

Review comment:
       I found that optional named argument is not working here, even though I have do 
   
   ```
       @Override public boolean isOptional(int i) {
         return false;
         return i == 2;
       }
   ```
   I expect Calcite can detect required `timecol` has missing. I haven't figured out the reason of this.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org