You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/01/08 17:35:51 UTC

[GitHub] [commons-text] garydgregory commented on a change in pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del…

garydgregory commented on a change in pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del…
URL: https://github.com/apache/commons-text/pull/127#discussion_r364354913
 
 

 ##########
 File path: src/main/java/org/apache/commons/text/WordUtils.java
 ##########
 @@ -51,6 +51,18 @@ public WordUtils() {
       super();
     }
 
+    /* All common whitespaces as defined in Character.isWhitespace(char) */
+    private static final char[] WHITESPACE_CHARS =
+        { '\t', '\n', '\u000B', '\f', '\r', '\u001C', '\u001D', '\u001E', '\u001F', ' ' };
 
 Review comment:
   This seems like it will be a maintenance headache. Can the stock method `Character.isWhitespace()` be used?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services