[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10999: Fix flaky MultiNodesOfflineClusterIntegrationTest.testServerHardFailure()

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10999:
URL: https://github.com/apache/pinot/pull/10999#discussion_r1247142202


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiNodesOfflineClusterIntegrationTest.java:
##########
@@ -178,11 +178,12 @@ private void testCountStarQuery(int expectedNumServersQueried, boolean exception
       JsonNode exceptions = queryResult.get("exceptions");
       assertEquals(exceptions.size(), 2);
       JsonNode firstException = exceptions.get(0);
+      // NOTE:
+      // Only verify the error code but not the exception message because there can be different messages:
+      // - Connection refused
+      // - Connection reset
+      // - Channel is inactive
       assertEquals(firstException.get("errorCode").intValue(), QueryException.BROKER_REQUEST_SEND_ERROR_CODE);
-      String firstExceptionMessage = firstException.get("message").textValue();
-      assertTrue(
-          firstExceptionMessage.contains("Connection refused") || firstExceptionMessage.contains("Connection reset"),
-          "Got unexpected first exception message: " + firstExceptionMessage);

Review Comment:
   The message itself is not that important, and is from a third-party library, so ignoring the actual content should be fine



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org