You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/23 09:28:04 UTC

[GitHub] [airflow] potiuk edited a comment on pull request #19065: Remove incorrect type comment in Swagger2Specification._set_defaults classmethod

potiuk edited a comment on pull request #19065:
URL: https://github.com/apache/airflow/pull/19065#issuecomment-950123505


   We usually don't chenge vendored code. We could potentially exclude the connexion package from `mypy` checks but (from what I understand) in this case it is not "airflow's" mypy that fails but the problem is that if the user want to check their own DAG that imports airflow. It would be a bit too much to require from our users to exclude the package with their mypy checks, and since the fix is simple (and without any runtime code change), and the same fix is already done in  upstream, I see no reason why we should not merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org