You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/02/08 08:02:05 UTC

[GitHub] [incubator-uniffle] kaijchen opened a new issue, #562: [Improvement] Sleep with lock held in ShuffleTaskManager

kaijchen opened a new issue, #562:
URL: https://github.com/apache/incubator-uniffle/issues/562

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   Sleep at line 257 with lock held:
   
   https://github.com/apache/incubator-uniffle/blob/24ea73cf8b4d9a9a270bd2ca798b571a2b8b4917/server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java#L235-L269
   
   ### How should we improve?
   
   Can we avoid polling here?
   For example: use `lock.await()`.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org