You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2026/09/03 15:24:20 UTC
[PR] Reduce log verbosity of NoSQL persistence tests [polaris]
adutra opened a new pull request, #5440:
URL: https://github.com/apache/polaris/pull/5440
A few loggers were at INFO, DEBUG or even TRACE. Changed all of these to ERROR to reduce verbosity.
<!--
📝 Describe what changes you're proposing, especially breaking or user-facing changes.
📖 See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
-->
## Checklist
- [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
- [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
- [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
- [ ] 💡 Added comments for complex logic
- [ ] 🧾 Updated `CHANGELOG.md` (if needed)
- [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce log verbosity of NoSQL persistence tests [polaris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #5440:
URL: https://github.com/apache/polaris/pull/5440#discussion_r3926060763
##########
persistence/nosql/persistence/metastore-maintenance/src/test/resources/logback-test.xml:
##########
@@ -26,9 +26,9 @@
<pattern>%date{ISO8601} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>
- <root level="DEBUG">
+ <root level="${test.log.level:-ERROR}">
<appender-ref ref="console"/>
</root>
- <logger name="org.jboss" level="INFO"/>
- <logger name="org.apache.polaris" level="DEBUG"/>
+ <logger name="org.jboss" level="ERROR"/>
+ <logger name="org.apache.polaris" level="ERROR"/>
Review Comment:
With `org.apache.polaris` pinned to ERROR, raising `-Dtest.log.level` won’t increase Polaris log output even though the root logger is configurable. Consider using `${test.log.level}` for the Polaris logger (or removing the explicit logger) so developers can opt into more logging when diagnosing failures.
##########
persistence/nosql/persistence/metastore-types/src/test/resources/logback-test.xml:
##########
@@ -26,9 +26,9 @@
<pattern>%date{ISO8601} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>
- <root level="DEBUG">
+ <root level="${test.log.level:-ERROR}">
<appender-ref ref="console"/>
</root>
- <logger name="org.jboss" level="INFO"/>
- <logger name="org.apache.polaris" level="DEBUG"/>
+ <logger name="org.jboss" level="ERROR"/>
+ <logger name="org.apache.polaris" level="ERROR"/>
Review Comment:
`-Dtest.log.level=...` won’t affect Polaris logs here because `org.apache.polaris` is explicitly set to ERROR while the root logger is configurable. Using `${test.log.level}` for the Polaris logger (or removing the explicit logger) keeps the default quiet while still allowing higher verbosity when debugging.
##########
persistence/nosql/persistence/metastore/src/test/resources/logback-test.xml:
##########
@@ -26,10 +26,10 @@
<pattern>%date{ISO8601} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>
- <root level="TRACE">
+ <root level="${test.log.level:-ERROR}">
<appender-ref ref="console"/>
</root>
- <logger name="org.jboss" level="INFO"/>
- <logger name="org.apache.polaris" level="DEBUG"/>
- <logger name="org.apache.polaris.persistence.nosql.metastore" level="TRACE"/>
+ <logger name="org.jboss" level="ERROR"/>
+ <logger name="org.apache.polaris" level="ERROR"/>
+ <logger name="org.apache.polaris.persistence.nosql.metastore" level="ERROR"/>
Review Comment:
The per-package loggers are pinned to ERROR, so setting `-Dtest.log.level=...` won’t increase verbosity for Polaris classes even though the root logger is now configurable. Consider tying the Polaris logger levels to the same `${test.log.level}` property (or removing these explicit logger entries) so the override works as expected when debugging tests.
##########
persistence/nosql/persistence/cdi/quarkus-distcache/src/test/resources/logback-test.xml:
##########
@@ -24,11 +24,11 @@
<pattern>%date{ISO8601} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>
- <root level="INFO">
+ <root level="${test.log.level:-ERROR}">
<appender-ref ref="console"/>
</root>
- <logger name="org.jboss" level="INFO"/>
- <logger name="org.apache.polaris" level="DEBUG"/>
- <logger name="org.apache.polaris.persistence.nosql.metastore" level="TRACE"/>
- <logger name="org.apache.polaris.persistence.nosql.quarkus.distcache" level="TRACE"/>
+ <logger name="org.jboss" level="ERROR"/>
+ <logger name="org.apache.polaris" level="ERROR"/>
+ <logger name="org.apache.polaris.persistence.nosql.metastore" level="ERROR"/>
+ <logger name="org.apache.polaris.persistence.nosql.quarkus.distcache" level="ERROR"/>
Review Comment:
The Polaris package loggers are hard-coded to ERROR, so `-Dtest.log.level=DEBUG` won’t increase verbosity for these namespaces even though the root logger is now configurable. Consider using `${test.log.level}` for the Polaris loggers (or removing the explicit logger entries) to keep the default quiet while still allowing easy opt-in debug logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce log verbosity of NoSQL persistence tests [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #5440:
URL: https://github.com/apache/polaris/pull/5440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce log verbosity of NoSQL persistence tests [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #5440:
URL: https://github.com/apache/polaris/pull/5440#discussion_r3926254903
##########
persistence/nosql/persistence/cdi/quarkus-distcache/src/test/resources/logback-test.xml:
##########
@@ -24,11 +24,11 @@
<pattern>%date{ISO8601} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>
- <root level="INFO">
+ <root level="${test.log.level:-ERROR}">
<appender-ref ref="console"/>
</root>
- <logger name="org.jboss" level="INFO"/>
- <logger name="org.apache.polaris" level="DEBUG"/>
- <logger name="org.apache.polaris.persistence.nosql.metastore" level="TRACE"/>
- <logger name="org.apache.polaris.persistence.nosql.quarkus.distcache" level="TRACE"/>
+ <logger name="org.jboss" level="ERROR"/>
+ <logger name="org.apache.polaris" level="ERROR"/>
+ <logger name="org.apache.polaris.persistence.nosql.metastore" level="ERROR"/>
+ <logger name="org.apache.polaris.persistence.nosql.quarkus.distcache" level="ERROR"/>
Review Comment:
Setting all loggers to `${test.log.level:-ERROR}` effectively boils down to removing those loggers since they become identical to the root logger. Not sure I agree. I think it's easy enough to just modify this file if someone needs to debug some specific logger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org