You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/31 08:20:29 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5913: arch/risc-v: Move group_addrenv to correct place

xiaoxiang781216 edited a comment on pull request #5913:
URL: https://github.com/apache/incubator-nuttx/pull/5913#issuecomment-1084252272


   > For the up_disable_irq/up_enable_irq, it's added in this PR for all risc-v chips, to minimal the side effect, I'll remove it to keep the code behavior as before.
   
   It's look wrong to disable/enable irq here, since the global IE bit is already off in this function. let’s create a patch remove them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org