You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/30 11:49:46 UTC
[GitHub] [airflow] agrubb86 opened a new issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
agrubb86 opened a new issue #18634:
URL: https://github.com/apache/airflow/issues/18634
### Describe the issue with documentation
With the upgrade from Pendulum 1.x to 2.x that coincides with upgrading from Airflow 1.x to 2.x, there are some breaking changes that aren't mentioned here:
[https://airflow.apache.org/docs/apache-airflow/stable/upgrading-from-1-10/index.html](Upgrading from 1.x to 2.x)
The specific breaking change I experienced is the .copy() method is completely removed in Pendulum 2.x. It turns out this isn't needed in my case as each macro that provides a pendulum.Pendulum provides a brand new instance, but it still caught me by surprise.
I also noticed that the stable documentation (2.1.4 at time of writing) for macros still links to Pendulum 1.x:
[https://airflow.apache.org/docs/apache-airflow/stable/macros-ref.html](Macros reference)
Specifically the macros: execution_date, prev_execution_date, prev_execution_date_success, prev_start_date_success, next_execution_date
### How to solve the problem
The macros reference links definitely need to be changed to Pendulum 2.x, maybe it would be a nice-to-have in the 1.x -> 2.x documentation but I was effectively using .copy() in a misguided way so I wouldn't say it's totally necessary.
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] 1nF0rmed commented on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
1nF0rmed commented on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-942151610
I would like to pick this up. Can you point me to where these are documented? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] 1nF0rmed commented on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
1nF0rmed commented on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-939330076
@uranusjr In that case, should we avoid adding it in the upgrade documentation? and just focus on updating the pendulum references?
Also, could you point me to where I would have to make changes for the same?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-942226149
https://airflow.apache.org/docs/apache-airflow/stable/upgrading-from-1-10/index.html - > and you can open PR straight from there via "Suggest a change on this page" button @1nF0rmed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-940561574
We can call out Pendulum is upgraded to 2.x, and you cannot use Pendulum 1.x with Airflow 2.x. The `formatter` argument can be used as an example to tell the user to check out Pendulum's documentation for what exactly they need to fix.
This should probably be added somewhere near (or as a part of) *Step 5: Upgrade Airflow DAGs*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-939187798
The `format` function in Pendulum 2.x does not accept the `formatter` argument at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-939187798
The `format` function in Pendulum 2.x does not accept the `formatter` argument at all. In 1.x, the formatter can be specified as either `classic` or `alternative, which selects a formatter class, although I've never personally understood what exactly the difference this makes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-939187798
The `format` function in Pendulum 2.x does not accept the `formatter` argument at all. In 1.x, the formatter can be specified as either `classic` or `alternative`, which selects a formatter class, although I've never personally understood what exactly the difference this makes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] 1nF0rmed commented on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
1nF0rmed commented on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-939002571
What errors do `execution_date.format('YYYY-MM-DD HH:mm:ss', formatter='alternative')` throw at the moment?
Also, could you point me where `execution_date.format('YYYY-MM-DD HH:mm:ss', formatter='alternative')` is documented (the formatter parameter)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] 1nF0rmed commented on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
1nF0rmed commented on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-942151610
I would like to pick this up. Can you point me to where these are documented? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-939187798
The `format` function in Pendulum 2.x does not accept the `formatter` argument at all. In 1.x, the formatter can be specified as either `classic` or `alternative, which selects a formatter class, although I've never personally understood what exactly the difference is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #18634: Pendulum 1.x -> 2.x with Airflow 1.x -> 2.x Documentation Updates
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #18634:
URL: https://github.com/apache/airflow/issues/18634#issuecomment-942226149
https://airflow.apache.org/docs/apache-airflow/stable/upgrading-from-1-10/index.html - > and you can open PR straight from there via "Suggest a change on this page" button @1nF0rmed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org