You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "GayathriSrividya (via GitHub)" <gi...@apache.org> on 2026/06/03 10:33:08 UTC

[PR] UI: Fix task instance state badge staying stale after Mark-as action [airflow]

GayathriSrividya opened a new pull request, #67950:
URL: https://github.com/apache/airflow/pull/67950

   After marking a task instance as success/failed/skipped, the state badge
   on the task instance detail page does not update until a manual page reload.
   
   The root cause is in `usePatchTaskInstance`: the `GetMappedTaskInstance`
   query was invalidated using the full 4-field key
   `UseTaskInstanceServiceGetMappedTaskInstanceKeyFn({ dagId, dagRunId, mapIndex, taskId })`.
   While this exact key should theoretically match, TanStack Query's
   `partialDeepEqual` matching is more reliable when the search key is a
   **subset** of the cached key rather than an exact match.
   
   `usePatchDagRun` already uses the partial-key pattern for the same query:
   ```ts
   [useTaskInstanceServiceGetMappedTaskInstanceKey, { dagId, dagRunId }]
   ```
   
   This PR aligns `usePatchTaskInstance` to the same approach, using
   `[useTaskInstanceServiceGetMappedTaskInstanceKey, { dagId, dagRunId, taskId }]`
   as a partial key that matches any `mapIndex` for the given task. This also
   eliminates the separate predicate-based invalidation that was needed for the
   "patch all mapped TIs" case (`mapIndex === undefined`), simplifying the code.
   
   closes: #67883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] UI: Fix task instance state badge staying stale after Mark-as action [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #67950:
URL: https://github.com/apache/airflow/pull/67950#issuecomment-4616322482

   ### Backport failed to create: v3-2-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/26910183592'> Run details </a>
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
       <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>❌</td>
           <td>v3-2-test</td>
           <td><a href="https://github.com/apache/airflow/commit/ed10d7b053feedf6faa39b153df9e6df62dfa35b"><img src='https://img.shields.io/badge/Commit-ed10d7b-red' alt='Commit Link'></a></td>
       </tr>
   </table>
   
   You can attempt to backport this manually by running:
   
   ```bash
   cherry_picker ed10d7b v3-2-test
   ```
   
   This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
   the files that need manual conflict resolution.
   
   After you have resolved the conflicts, you can continue the backport process by running:
   
   ```bash
   cherry_picker --continue
   ```
   
   If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] UI: Fix task instance state badge staying stale after Mark-as action [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #67950:
URL: https://github.com/apache/airflow/pull/67950


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org