[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1421: .gitignore: Don't ignore directories that have the .d extenion.

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #1421:
URL: https://github.com/apache/incubator-nuttx/pull/1421#discussion_r456826446



##########
File path: boards/sim/sim/sim/src/.gitignore
##########
@@ -1,2 +1 @@
 /etctmp*
-!/etc/**

Review comment:
       That change was part of #1373 to solve the *.d issue.  I don't know if we should allow anything in that folder, if you think we should I can bring it back.
   > I guess going forward we should just be careful when people force the inclusion of a file and instead have a specific git ignore exception for it.
   
   I agree with this.  But does this apply to this change?  I guess somehow it does since at the very beginning the idea was to bring the rcS file back.
   But what I'm trying to do is the have a general way to include *.d folders since we may have more of them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org