You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/07 16:14:03 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #12154: Provider packages are installed by default in production image

mik-laj commented on a change in pull request #12154:
URL: https://github.com/apache/airflow/pull/12154#discussion_r519192423



##########
File path: scripts/ci/images/ci_prepare_prod_image_on_ci.sh
##########
@@ -48,4 +48,61 @@ function build_prod_images_on_ci() {
 }
 
 
+
+function verify_prod_image_has_airflow_and_providers {

Review comment:
       Can you add a test that will check if at least one provider can be loaded? This will give us the greatest confidence that everything is working.
   ```
   python -c "from airflow.providers.google.common.hooks.base_google import GoogleBaseHook"
   ```
   We may have these files in the image, but for various reasons they may not be loaded by Python, e.g. due to invalid permissions.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org