You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2011/04/12 21:51:49 UTC
svn commit: r1091561 - in
/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3:
POP3ClientCommandsTest.java POP3ClientTest.java
Author: sebb
Date: Tue Apr 12 19:51:49 2011
New Revision: 1091561
URL: http://svn.apache.org/viewvc?rev=1091561&view=rev
Log:
Revert 1087549 - NET-396 - as setState() does need to be public
Part deux
Modified:
commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java
Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java?rev=1091561&r1=1091560&r2=1091561&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java Tue Apr 12 19:51:49 2011
@@ -102,7 +102,7 @@ public class POP3ClientCommandsTest exte
assertTrue(p.noop());
//Should fail in update state
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
assertFalse(p.noop());
}
@@ -140,7 +140,7 @@ public class POP3ClientCommandsTest exte
reset();
connect();
login();
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
assertNull(p.status());
}
@@ -166,7 +166,7 @@ public class POP3ClientCommandsTest exte
}
//Now test from the update state
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
msg = p.listMessages();
assertNull(msg);
}
@@ -201,7 +201,7 @@ public class POP3ClientCommandsTest exte
assertNull(msg);
//Now try to get a valid message from the update state
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
msg = p.listMessage(1);
assertNull(msg);
}
@@ -220,7 +220,7 @@ public class POP3ClientCommandsTest exte
assertEquals(0, msg.length);
//Now test from the update state
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
msg = p.listMessages();
assertNull(msg);
}
@@ -261,7 +261,7 @@ public class POP3ClientCommandsTest exte
}
//Now test from the update state
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
msg = p.listUniqueIdentifiers();
assertNull(msg);
}
@@ -295,7 +295,7 @@ public class POP3ClientCommandsTest exte
assertNull(msg);
//Now try to get a valid message from the update state
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
msg = p.listUniqueIdentifier(1);
assertNull(msg);
}
@@ -314,7 +314,7 @@ public class POP3ClientCommandsTest exte
assertEquals(0, msg.length);
//Now test from the update state
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
msg = p.listUniqueIdentifiers();
assertNull(msg);
}
@@ -414,7 +414,7 @@ public class POP3ClientCommandsTest exte
assertNull(p.retrieveMessage(100000));
//Change states and try to get a valid message
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
assertNull(p.retrieveMessage(1));
}
@@ -518,7 +518,7 @@ public class POP3ClientCommandsTest exte
assertNull(p.retrieveMessageTop(100000, 10));
//Change states and try to get a valid message
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
assertNull(p.retrieveMessageTop(1, 10));
}
@@ -593,7 +593,7 @@ public class POP3ClientCommandsTest exte
connect();
login();
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
assertFalse(p.reset());
assertFalse(p.deleteMessage(1));
Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java?rev=1091561&r1=1091560&r2=1091561&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java Tue Apr 12 19:51:49 2011
@@ -136,13 +136,13 @@ public class POP3ClientTest extends Test
//Now connect and set the state to 'transaction' and try again
connect();
- p._setState(POP3.TRANSACTION_STATE);
+ p.setState(POP3.TRANSACTION_STATE);
assertFalse(p.login(user, password));
p.disconnect();
//Now connect and set the state to 'update' and try again
connect();
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
assertFalse(p.login(user, password));
p.disconnect();
}
@@ -164,7 +164,7 @@ public class POP3ClientTest extends Test
reset();
connect();
login();
- p._setState(POP3.UPDATE_STATE);
+ p.setState(POP3.UPDATE_STATE);
assertTrue(p.logout());
}
}