You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by "marios@redhat.com" <ma...@redhat.com> on 2011/07/11 15:23:21 UTC
Re: [PATCH] Restores delete firewall rule semantics:
Hi Chris, sorry for the delay -
at first I was sceptical about the usefulness of exposing the rule URI
since it doesn't make sense to 'retrieve' (GET) a single rule. However I
agree that it makes sense to expose the rule URI as we have a 'DELETE
rule_id' operation. I'll send an updated patch and will commit as soon
as you ack that,
marios
On 30/06/11 23:44, Chris Lalancette wrote:
> On 06/27/11 - 05:22:18PM, marios@redhat.com wrote:
>> From: marios<ma...@redhat.com>
>>
>> DELETE /api/firewalls/:firewall/:rule_id
>>
>> Signed-off-by: marios<ma...@redhat.com>
>> ---
>> server/lib/deltacloud/drivers/ec2/ec2_driver.rb | 2 +-
>> server/server.rb | 31 ++++++++++------------
>> server/views/firewalls/show.html.haml | 3 +-
>> 3 files changed, 16 insertions(+), 20 deletions(-)
>
> Hey Marios,
> Sorry for the long delay here. This patch is most of what I would like
> to see, though there is one thing missing. In the XML for the firewall rule,
> I think we should export the URL for the rule as well, similar to how blobs
> have a full URL. Something like this (untested) patch?
>