You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/03/11 20:58:01 UTC
[royale-asjs] branch develop updated: jewel-tabbar: some little
updates to tabbar recent refactor
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 43defcc jewel-tabbar: some little updates to tabbar recent refactor
43defcc is described below
commit 43defccaa0f8790a4243bbda39fbab4edd1cf767
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Wed Mar 11 21:57:50 2020 +0100
jewel-tabbar: some little updates to tabbar recent refactor
---
.../main/royale/org/apache/royale/jewel/TabBar.as | 2 +-
.../itemRenderers/TabBarItemRendererInitializer.as | 57 ++++------------------
2 files changed, 11 insertions(+), 48 deletions(-)
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TabBar.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TabBar.as
index 514bf5d..2d8ac53 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TabBar.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TabBar.as
@@ -56,7 +56,7 @@ package org.apache.royale.jewel
//TabBar is always selected, so selectedIndex can't be -1, at least it will default to 0
ISelectionModel(model).selectedIndex = 0;
- // rowHeight is not set byt default, so set it to NaN
+ // rowHeight is not set by default, so set it to NaN
rowHeight = NaN;
addEventListener(MouseEvent.CLICK, internalMouseHandler);
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TabBarItemRendererInitializer.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TabBarItemRendererInitializer.as
index 932f36c..6f578aa 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TabBarItemRendererInitializer.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TabBarItemRendererInitializer.as
@@ -18,27 +18,19 @@
////////////////////////////////////////////////////////////////////////////////
package org.apache.royale.jewel.beads.itemRenderers
{
- import org.apache.royale.core.IIndexedItemRenderer;
- import org.apache.royale.core.IIndexedItemRendererInitializer;
- import org.apache.royale.core.IItemRendererOwnerView;
- import org.apache.royale.core.IStrand;
- import org.apache.royale.core.IStrandWithModelView;
- import org.apache.royale.core.IStrandWithPresentationModel;
- import org.apache.royale.core.StyledMXMLItemRenderer;
- import org.apache.royale.core.UIBase;
- import org.apache.royale.html.beads.IndexedItemRendererInitializer;
- import org.apache.royale.jewel.supportClasses.list.IListPresentationModel;
-
/**
* The TabBarItemRendererInitializer class initializes item renderers
- * in list classes.
+ * in TabBar component.
+ *
+ * By Default this works the same as ListItemRendererInitializer, but create a placeholder
+ * for it.
*
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
* @productversion Royale 0.9.7
*/
- public class TabBarItemRendererInitializer extends IndexedItemRendererInitializer implements IIndexedItemRendererInitializer
+ public class TabBarItemRendererInitializer extends ListItemRendererInitializer
{
/**
* constructor.
@@ -51,40 +43,11 @@ package org.apache.royale.jewel.beads.itemRenderers
public function TabBarItemRendererInitializer()
{
}
-
- protected var presentationModel:IListPresentationModel;
- private var ownerView:IItemRendererOwnerView;
-
- /**
- * @copy org.apache.royale.core.IBead#strand
- *
- * @langversion 3.0
- * @playerversion Flash 10.2
- * @playerversion AIR 2.6
- * @productversion Royale 0.9.7
- * @royaleignorecoercion HTMLInputElement
- * @royaleignorecoercion org.apache.royale.core.UIBase;
- */
- override public function set strand(value:IStrand):void
- {
- super.strand = value;
- ownerView = (value as IStrandWithModelView).view as IItemRendererOwnerView;
- presentationModel = (_strand as IStrandWithPresentationModel).presentationModel as IListPresentationModel;
- }
- override protected function setupVisualsForItemRenderer(ir:IIndexedItemRenderer):void
- {
- if (presentationModel) {
- UIBase(ir).height = presentationModel.rowHeight;
-
- if(ir is IAlignItemRenderer)
- {
- (ir as IAlignItemRenderer).align = presentationModel.align;
- }
- }
- if (ir is StyledMXMLItemRenderer && ownerView)
- (ir as StyledMXMLItemRenderer).itemRendererOwnerView = ownerView;
- }
-
+ // override protected function setupVisualsForItemRenderer(ir:IIndexedItemRenderer):void
+ // {
+ // super.setupVisualsForItemRenderer(ir);
+ // trace("[TabBarItemRendererInitializer]");
+ // }
}
}