[jira] Commented: (SLING-1250) Changing content loader to use o.a.s.jcr.api 2.0.4 broke a few tests

["Justin Edelson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791985#action_12791985 ] 

Justin Edelson commented on SLING-1250:
---------------------------------------

BTW, it looks like this patch needs to be applied with -p1, not -p0.

> Changing content loader to use o.a.s.jcr.api 2.0.4 broke a few tests
> --------------------------------------------------------------------
>
>                 Key: SLING-1250
>                 URL: https://issues.apache.org/jira/browse/SLING-1250
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad
>            Reporter: Justin Edelson
>         Attachments: SLING-1250.patch
>
>
> After r891573, these tests fail from launchpad/testing:
> > org.apache.sling.launchpad.webapp.integrationtest.HttpPingTest.testWebServerRoot
> > org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest.testIndex
> > org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest.testRootRedirectProperty
> > org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest.testInitialContentA
> > org.apache.sling.launchpad.webapp.integrationtest.InitialContentTest.testInitialContentB
> This is because the dependency from o.a.s.jcr.contentloader to o.a.s.jcr.api was changed from version 2.0.2-incubator to 2.0.4. However, launchpad/bundles/pom.xml includes 2.0.2-incubator of o.a.s.jcr.api, so this is an unresolved import, leading to the failure of initial content loader.
> Simply upgrading launchpad/bundles/pom.xml is insufficient, however, because (per SLING-1052) o.a.s.jcr.api no longer exports the JCR API.
> However, I can't find an OSGi-fied version of the JCR 1.0 API. The patch I'll attach here adds the 2.0 API and fixes the tests, but it doesn't feel right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.