[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more canonical

[GitBox <gi...@apache.org>]

MichaelChirico commented on a change in pull request #28365:
URL: https://github.com/apache/spark/pull/28365#discussion_r417512826



##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -2558,7 +2558,7 @@ test_that("join(), crossJoin() and merge() on a DataFrame", {
   error_msg <- paste("joinType must be one of the following types:",
                  "'inner', 'cross', 'outer', 'full', 'fullouter', 'full_outer',",
                  "'left', 'leftouter', 'left_outer', 'right', 'rightouter', 'right_outer',",
-                 "'semi', 'leftsemi', 'left_semi', 'anti', 'leftanti' or 'left_anti'.")
+                 "'semi', 'left_semi', 'leftsemi', 'anti', 'left_anti', 'leftanti'")

Review comment:
       OK. I picked between the order in the error message and that in the `%in%` test a few lines above arbitrarily. I'll switch it around. The test will still change slightly since the error is easier to write without being too careful about the `or` at the end.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org