You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2008/04/01 21:38:57 UTC

svn commit: r643531 - in /httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn: AbstractPoolEntry.java AbstractPooledConnAdapter.java

Author: olegk
Date: Tue Apr  1 12:38:50 2008
New Revision: 643531

URL: http://svn.apache.org/viewvc?rev=643531&view=rev
Log:
HTTPCLIENT-741: More concurrency fixes in HttpConn classes
Contributed by Tim Julien <tjulien at limewire.com>
Reviewed by Oleg Kalnichevski

Modified:
    httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPoolEntry.java
    httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPooledConnAdapter.java

Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPoolEntry.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPoolEntry.java?rev=643531&r1=643530&r2=643531&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPoolEntry.java (original)
+++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPoolEntry.java Tue Apr  1 12:38:50 2008
@@ -69,16 +69,16 @@
 public abstract class AbstractPoolEntry {
 
     /** The underlying connection being pooled or used. */
-    protected OperatedClientConnection connection;
+    protected volatile OperatedClientConnection connection;
 
     /** The route for which this entry gets allocated. */
     //@@@ currently accessed from connection manager(s) as attribute
     //@@@ avoid that, derived classes should decide whether update is allowed
     //@@@ SCCM: yes, TSCCM: no
-    protected HttpRoute plannedRoute;
+    protected volatile HttpRoute plannedRoute;
 
     /** The tracked route, or <code>null</code> before tracking starts. */
-    protected RouteTracker tracker;
+    protected volatile RouteTracker tracker;
 
 
     /**

Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPooledConnAdapter.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPooledConnAdapter.java?rev=643531&r1=643530&r2=643531&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPooledConnAdapter.java (original)
+++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/AbstractPooledConnAdapter.java Tue Apr  1 12:38:50 2008
@@ -63,7 +63,7 @@
 public abstract class AbstractPooledConnAdapter extends AbstractClientConnAdapter {
 
     /** The wrapped pool entry. */
-    protected AbstractPoolEntry poolEntry;
+    protected volatile AbstractPoolEntry poolEntry;
 
 
     /**