You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/09/15 17:50:33 UTC
Review Request 62358: Replaced xlocale.h with locale.h.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62358/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-7980
https://issues.apache.org/jira/browse/MESOS-7980
Repository: mesos
Description
-------
As of glibc 2.26, xlocale.h has been removed as this was never supposed
to be used directly by user programs. They should be including locale.h
instead.
Diffs
-----
3rdparty/stout/include/stout/jsonify.hpp 06b18e27672c45a1d6ab93e4595419200c590ae4
Diff: https://reviews.apache.org/r/62358/diff/1/
Testing
-------
make check with glibc 2.26.
Thanks,
Kapil Arya
Re: Review Request 62358: Replaced xlocale.h with locale.h.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62358/#review185500
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Sept. 15, 2017, 6:10 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62358/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 6:10 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-7980
> https://issues.apache.org/jira/browse/MESOS-7980
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As of glibc 2.26, xlocale.h has been removed as this was never supposed
> to be used directly by user programs. They should be including locale.h
> instead.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/jsonify.hpp 06b18e27672c45a1d6ab93e4595419200c590ae4
>
>
> Diff: https://reviews.apache.org/r/62358/diff/1/
>
>
> Testing
> -------
>
> make with glibc 2.26.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62358: Replaced xlocale.h with locale.h.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62358/
-----------------------------------------------------------
(Updated Sept. 15, 2017, 2:10 p.m.)
Review request for mesos and Till Toenshoff.
Bugs: MESOS-7980
https://issues.apache.org/jira/browse/MESOS-7980
Repository: mesos
Description
-------
As of glibc 2.26, xlocale.h has been removed as this was never supposed
to be used directly by user programs. They should be including locale.h
instead.
Diffs
-----
3rdparty/stout/include/stout/jsonify.hpp 06b18e27672c45a1d6ab93e4595419200c590ae4
Diff: https://reviews.apache.org/r/62358/diff/1/
Testing (updated)
-------
make with glibc 2.26.
Thanks,
Kapil Arya