You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/16 08:44:38 UTC
[GitHub] [cloudstack] slavkap opened a new pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
slavkap opened a new pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826
### Description
This PR allows the rest of the storage plugins to implement and use the storage/volume statistics directly instead of sending cmd to hosts, not only ScaleIO. With this change, we check if the plugin could provide storage/volume statistics.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Feature/Enhancement Scale
- [ ] Major
- [ X] Minor
### How Has This Been Tested?
OS - CentOS7
hypervisor - KVM
branch - master
primary storage - NFS, StorPool
manually tested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-920595863
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-920677944
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-895089598
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-927920321
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-921931020
<b>Trillian test result (tid-2105)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40667 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2105-vmware-67u3.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_live_migrate_VM_with_two_data_disks | `Error` | 59.68 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#discussion_r686697390
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -475,49 +478,40 @@ public Answer sendToPool(StoragePool pool, Command cmd) throws StorageUnavailabl
}
private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool, GetStorageStatsCommand cmd) {
- DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
- DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
GetStorageStatsAnswer answer = null;
- if (storeDriver instanceof PrimaryDataStoreDriver && ((PrimaryDataStoreDriver)storeDriver).canProvideStorageStats()) {
- PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver)storeDriver;
- Pair<Long, Long> storageStats = primaryStoreDriver.getStorageStats(pool);
- if (storageStats == null) {
- answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, "Failed to get storage stats for pool: " + pool.getId());
- } else {
- answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, storageStats.first(), storageStats.second());
- }
+ DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
+ DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
+ PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver) storeDriver;
Review comment:
can this cause a class cast exception? there used to be a check for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#discussion_r686885121
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -475,49 +478,40 @@ public Answer sendToPool(StoragePool pool, Command cmd) throws StorageUnavailabl
}
private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool, GetStorageStatsCommand cmd) {
- DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
- DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
GetStorageStatsAnswer answer = null;
- if (storeDriver instanceof PrimaryDataStoreDriver && ((PrimaryDataStoreDriver)storeDriver).canProvideStorageStats()) {
- PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver)storeDriver;
- Pair<Long, Long> storageStats = primaryStoreDriver.getStorageStats(pool);
- if (storageStats == null) {
- answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, "Failed to get storage stats for pool: " + pool.getId());
- } else {
- answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, storageStats.first(), storageStats.second());
- }
+ DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
+ DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
+ PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver) storeDriver;
Review comment:
got it, but please do, no telling who will call it in the future and from where.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-919804337
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#discussion_r595734622
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -460,50 +463,37 @@ public Answer sendToPool(StoragePool pool, Command cmd) throws StorageUnavailabl
return answers[0];
}
- private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool, GetStorageStatsCommand cmd) {
- DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
- DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
+ private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool, GetStorageStatsCommand cmd, DataStoreDriver storeDriver) {
GetStorageStatsAnswer answer = null;
- if (storeDriver instanceof PrimaryDataStoreDriver && ((PrimaryDataStoreDriver)storeDriver).canProvideStorageStats()) {
- PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver)storeDriver;
- Pair<Long, Long> storageStats = primaryStoreDriver.getStorageStats(pool);
- if (storageStats == null) {
- answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, "Failed to get storage stats for pool: " + pool.getId());
- } else {
- answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, storageStats.first(), storageStats.second());
- }
+ PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver) storeDriver;
+ Pair<Long, Long> storageStats = primaryStoreDriver.getStorageStats(pool);
+ if (storageStats == null) {
+ answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, "Failed to get storage stats for pool: " + pool.getId());
+ } else {
+ answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, storageStats.first(), storageStats.second());
}
return answer;
}
@Override
- public Answer getVolumeStats(StoragePool pool, Command cmd) {
- if (!(cmd instanceof GetVolumeStatsCommand)) {
- return null;
- }
-
- DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
- DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
-
- if (storeDriver instanceof PrimaryDataStoreDriver && ((PrimaryDataStoreDriver)storeDriver).canProvideVolumeStats()) {
- PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver)storeDriver;
- HashMap<String, VolumeStatsEntry> statEntry = new HashMap<String, VolumeStatsEntry>();
- GetVolumeStatsCommand getVolumeStatsCommand = (GetVolumeStatsCommand) cmd;
- for (String volumeUuid : getVolumeStatsCommand.getVolumeUuids()) {
- Pair<Long, Long> volumeStats = primaryStoreDriver.getVolumeStats(pool, volumeUuid);
- if (volumeStats == null) {
- return new GetVolumeStatsAnswer(getVolumeStatsCommand, "Failed to get stats for volume: " + volumeUuid, null);
- } else {
- VolumeStatsEntry volumeStatsEntry = new VolumeStatsEntry(volumeUuid, volumeStats.first(), volumeStats.second());
- statEntry.put(volumeUuid, volumeStatsEntry);
- }
+ public Answer getVolumeStats(StoragePool pool, Command cmd, DataStoreDriver storeDriver) {
Review comment:
same here, can you pick `storeDriver` from the pool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-919715476
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-929489583
<b>Trillian test result (tid-2227)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31594 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2227-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-896699134
@sureshanaparti do you :+1: :question:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-919713060
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-920678513
@sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-928844731
@rhtyd, @sureshanaparti, I took a look at the tests and the exception, but the problem is the same. It points to a line with a comment in a different method. Is it possible that the build is not from this PR? This PR should not affect the migration with volumes call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-895049559
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-896060881
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-927896871
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-921211568
<b>Trillian test result (tid-2087)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40377 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2087-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#discussion_r595734259
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -460,50 +463,37 @@ public Answer sendToPool(StoragePool pool, Command cmd) throws StorageUnavailabl
return answers[0];
}
- private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool, GetStorageStatsCommand cmd) {
- DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
- DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
+ private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool, GetStorageStatsCommand cmd, DataStoreDriver storeDriver) {
Review comment:
```suggestion
private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool, GetStorageStatsCommand cmd) {
```
@slavkap can you pick `storeDriver` from the pool itself, instead of explicitly pass as argument here.
```
DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-920614078
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-896422846
<b>Trillian test result (tid-1579)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37857 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t1579-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-896060632
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-926332304
ping @slavkap test failure is consistent, please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-921223727
<b>Trillian test result (tid-2088)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42490 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2088-vmware-65u2.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_live_migrate_VM_with_two_data_disks | `Error` | 61.75 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-925598978
re-triggering tests to check the error.
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-927896120
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-918839765
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-925599253
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-922633545
@slavkap can you check the test failure, it is consistent with VMware hypervisor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-927685547
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-929489583
<b>Trillian test result (tid-2227)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31594 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2227-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-928844731
@rhtyd, @sureshanaparti, I took a look at the tests and the exception, but the problem is the same. It points to a line with a comment in a different method. Is it possible that the build is not from this PR? This PR should not affect the migration with volumes call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-918839114
We need test matrix on this
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a change in pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
slavkap commented on a change in pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#discussion_r686708956
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -475,49 +478,40 @@ public Answer sendToPool(StoragePool pool, Command cmd) throws StorageUnavailabl
}
private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool, GetStorageStatsCommand cmd) {
- DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
- DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
GetStorageStatsAnswer answer = null;
- if (storeDriver instanceof PrimaryDataStoreDriver && ((PrimaryDataStoreDriver)storeDriver).canProvideStorageStats()) {
- PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver)storeDriver;
- Pair<Long, Long> storageStats = primaryStoreDriver.getStorageStats(pool);
- if (storageStats == null) {
- answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, "Failed to get storage stats for pool: " + pool.getId());
- } else {
- answer = new GetStorageStatsAnswer((GetStorageStatsCommand) cmd, storageStats.first(), storageStats.second());
- }
+ DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
+ DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
+ PrimaryDataStoreDriver primaryStoreDriver = (PrimaryDataStoreDriver) storeDriver;
Review comment:
@DaanHoogland, `getStoragePoolStats` is invoked only in `sendToPool` (the method above), and there is a check if the datastore driver is an instance of PrimaryDataStoreDriver. If you want, I could add a check and here, but at the moment, I don't think it is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-921480326
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-925234760
Ping @slavkap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-926118478
<b>Trillian test result (tid-2180)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41509 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2180-vmware-67u3.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_live_migrate_VM_with_two_data_disks | `Error` | 61.44 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-918889588
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-925518739
Hi @sureshanaparti, @rhtyd, sorry for not answering, but I needed a break and took a few days off. Unfortunately, I cannot find the problem with the test. The stack trace shows a null pointer exception at line 6508:
> 2021-09-17 12:32:31,667 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-105:ctx-2c8348f6 job-2321) (logid:5537f2da) Unexpected exception while executing org.apache.cloudstack.api.command.admin.vm.MigrateVirtualMachineWithVolumeCmd
> java.lang.NullPointerException
> at com.cloud.vm.UserVmManagerImpl.getVolumePoolMappingForMigrateVmWithStorage(UserVmManagerImpl.java:6508)
> at com.cloud.vm.UserVmManagerImpl.migrateVirtualMachineWithVolume(UserVmManagerImpl.java:6576)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
but this leads to commented part in the code of method `moveVMToUser` not `getVolumePoolMappingForMigrateVmWithStorage` :
```
6462 public UserVm moveVMToUser(final AssignVMCmd cmd) throws ResourceAllocationException, ConcurrentOperationException, ResourceUnavailableException, InsufficientCapacityException {
6463 // VERIFICATIONS and VALIDATIONS
6464
6465 // VV 1: verify the two users
6466 Account caller = CallContext.current().getCallingAccount();
6467 if (!_accountMgr.isRootAdmin(caller.getId())
6468 && !_accountMgr.isDomainAdmin(caller.getId())) { // only
6469 // root
6470 // admin
6471 // can
6472 // assign
6473 // VMs
6474 throw new InvalidParameterValueException("Only domain admins are allowed to assign VMs and not " + caller.getType());
6475 }
6476
6477 // get and check the valid VM
6478 final UserVmVO vm = _vmDao.findById(cmd.getVmId());
6479 if (vm == null) {
6480 throw new InvalidParameterValueException("There is no vm by that id " + cmd.getVmId());
6481 } else if (vm.getState() == State.Running) { // VV 3: check if vm is
6482 // running
6483 if (s_logger.isDebugEnabled()) {
6484 s_logger.debug("VM is Running, unable to move the vm " + vm);
6485 }
6486 InvalidParameterValueException ex = new InvalidParameterValueException("VM is Running, unable to move the vm with specified vmId");
6487 ex.addProxyObject(vm.getUuid(), "vmId");
6488 throw ex;
6489 }
6490
6491 final Account oldAccount = _accountService.getActiveAccountById(vm.getAccountId());
6492 if (oldAccount == null) {
6493 throw new InvalidParameterValueException("Invalid account for VM " + vm.getAccountId() + " in domain.");
6494 }
6495 final Account newAccount = _accountMgr.finalizeOwner(caller, cmd.getAccountName(), cmd.getDomainId(), cmd.getProjectId());
6496 if (newAccount == null) {
6497 throw new InvalidParameterValueException("Invalid accountid=" + cmd.getAccountName() + " in domain " + cmd.getDomainId());
6498 }
6499
6500 if (newAccount.getState() == Account.State.disabled) {
6501 throw new InvalidParameterValueException("The new account owner " + cmd.getAccountName() + " is disabled.");
6502 }
6503
6504 if (cmd.getProjectId() != null && cmd.getDomainId() == null) {
6505 throw new InvalidParameterValueException("Please provide a valid domain ID; cannot assign VM to a project if domain ID is NULL.");
6506 }
6507
6508 //check caller has access to both the old and new account
6509 _accountMgr.checkAccess(caller, null, true, oldAccount);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-927683084
Ping @slavkap (I'll kick another test matrix round, but still pl have a look)
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-921474337
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-920596209
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-927724410
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 1406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-921162564
<b>Trillian test result (tid-2086)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36665 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2086-xenserver-71.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-881502792
ping @slavkap can you please fix the conflicts. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-895049869
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org