You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Surya Hebbar (Code Review)" <ge...@cloudera.org> on 2026/03/02 07:31:37 UTC
[Impala-ASF-CR] IMPALA-14793: Replace row regex with aggregation tests
Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24058
Change subject: IMPALA-14793: Replace row regex with aggregation tests
......................................................................
IMPALA-14793: Replace row regex with aggregation tests
In the end-to-end python tests, there are many 'row_regex' searches
that can instead be treated as 'aggregation()' tests.
Rewriting these tests as aggregations can make the syntax easier,
while providing compatibility for both the traditional profile
and the new aggregated profile.
In many cases this results in better efficiency as the regex pattern to
search for is less complex than the original.
This is a split change associated with IMPALA-9846, in order to enable
the aggegated profile.
This reduces the number of lines from the large change IMPALA-9846
by a little, in order to aid the reviewer.
Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
---
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns-tpcds-partitioned-topn.test
M testdata/workloads/functional-query/queries/QueryTest/basic-spilling.test
M testdata/workloads/functional-query/queries/QueryTest/binary-type.test
M testdata/workloads/functional-query/queries/QueryTest/full-acid-original-file.test
M testdata/workloads/functional-query/queries/QueryTest/runtime_filters_mt_dop.test
M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-aggs.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-broadcast-joins.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-query-options.test
M testdata/workloads/functional-query/queries/QueryTest/spilling.test
M testdata/workloads/tpch/queries/tpch-passthrough-aggregations.test
M testdata/workloads/tpch/queries/tpch-q1.test
M testdata/workloads/tpch/queries/tpch-q10.test
M testdata/workloads/tpch/queries/tpch-q11.test
M testdata/workloads/tpch/queries/tpch-q12.test
M testdata/workloads/tpch/queries/tpch-q13.test
M testdata/workloads/tpch/queries/tpch-q14.test
M testdata/workloads/tpch/queries/tpch-q15.test
M testdata/workloads/tpch/queries/tpch-q16.test
M testdata/workloads/tpch/queries/tpch-q17.test
M testdata/workloads/tpch/queries/tpch-q18.test
M testdata/workloads/tpch/queries/tpch-q19.test
M testdata/workloads/tpch/queries/tpch-q2.test
M testdata/workloads/tpch/queries/tpch-q20.test
M testdata/workloads/tpch/queries/tpch-q21.test
M testdata/workloads/tpch/queries/tpch-q22.test
M testdata/workloads/tpch/queries/tpch-q3.test
M testdata/workloads/tpch/queries/tpch-q4.test
M testdata/workloads/tpch/queries/tpch-q5.test
M testdata/workloads/tpch/queries/tpch-q6.test
M testdata/workloads/tpch/queries/tpch-q7.test
M testdata/workloads/tpch/queries/tpch-q8.test
M testdata/workloads/tpch/queries/tpch-q9.test
33 files changed, 78 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/24058/1
--
To view, visit http://gerrit.cloudera.org:8080/24058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Gerrit-Change-Number: 24058
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-14793: Replace row regex with aggregation tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24058 )
Change subject: IMPALA-14793: Replace row regex with aggregation tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Gerrit-Change-Number: 24058
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 12:46:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14793: Replace row regex with aggregation tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24058 )
Change subject: IMPALA-14793: Replace row regex with aggregation tests
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13172/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Gerrit-Change-Number: 24058
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 12:46:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14793: Replace row regex with aggregation tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24058 )
Change subject: IMPALA-14793: Replace row regex with aggregation tests
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Gerrit-Change-Number: 24058
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 17:09:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14793: Replace row regex with aggregation tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24058 )
Change subject: IMPALA-14793: Replace row regex with aggregation tests
......................................................................
Patch Set 1: Code-Review+2
Thanks for doing this rewrite!
--
To view, visit http://gerrit.cloudera.org:8080/24058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Gerrit-Change-Number: 24058
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 12:46:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14793: Replace row regex with aggregation tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24058 )
Change subject: IMPALA-14793: Replace row regex with aggregation tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21829/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Gerrit-Change-Number: 24058
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 07:56:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14793: Replace row regex with aggregation tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24058 )
Change subject: IMPALA-14793: Replace row regex with aggregation tests
......................................................................
IMPALA-14793: Replace row regex with aggregation tests
In the end-to-end python tests, there are many 'row_regex' searches
that can instead be treated as 'aggregation()' tests.
Rewriting these tests as aggregations can make the syntax easier,
while providing compatibility for both the traditional profile
and the new aggregated profile.
In many cases this results in better efficiency as the regex pattern to
search for is less complex than the original.
This is a split change associated with IMPALA-9846, in order to enable
the aggegated profile.
This reduces the number of lines from the large change IMPALA-9846
by a little, in order to aid the reviewer.
Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Reviewed-on: http://gerrit.cloudera.org:8080/24058
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns-tpcds-partitioned-topn.test
M testdata/workloads/functional-query/queries/QueryTest/basic-spilling.test
M testdata/workloads/functional-query/queries/QueryTest/binary-type.test
M testdata/workloads/functional-query/queries/QueryTest/full-acid-original-file.test
M testdata/workloads/functional-query/queries/QueryTest/runtime_filters_mt_dop.test
M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-aggs.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-broadcast-joins.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-query-options.test
M testdata/workloads/functional-query/queries/QueryTest/spilling.test
M testdata/workloads/tpch/queries/tpch-passthrough-aggregations.test
M testdata/workloads/tpch/queries/tpch-q1.test
M testdata/workloads/tpch/queries/tpch-q10.test
M testdata/workloads/tpch/queries/tpch-q11.test
M testdata/workloads/tpch/queries/tpch-q12.test
M testdata/workloads/tpch/queries/tpch-q13.test
M testdata/workloads/tpch/queries/tpch-q14.test
M testdata/workloads/tpch/queries/tpch-q15.test
M testdata/workloads/tpch/queries/tpch-q16.test
M testdata/workloads/tpch/queries/tpch-q17.test
M testdata/workloads/tpch/queries/tpch-q18.test
M testdata/workloads/tpch/queries/tpch-q19.test
M testdata/workloads/tpch/queries/tpch-q2.test
M testdata/workloads/tpch/queries/tpch-q20.test
M testdata/workloads/tpch/queries/tpch-q21.test
M testdata/workloads/tpch/queries/tpch-q22.test
M testdata/workloads/tpch/queries/tpch-q3.test
M testdata/workloads/tpch/queries/tpch-q4.test
M testdata/workloads/tpch/queries/tpch-q5.test
M testdata/workloads/tpch/queries/tpch-q6.test
M testdata/workloads/tpch/queries/tpch-q7.test
M testdata/workloads/tpch/queries/tpch-q8.test
M testdata/workloads/tpch/queries/tpch-q9.test
33 files changed, 78 insertions(+), 78 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Gerrit-Change-Number: 24058
Gerrit-PatchSet: 3
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-14793: Replace row regex with aggregation tests
Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24058 )
Change subject: IMPALA-14793: Replace row regex with aggregation tests
......................................................................
Patch Set 3:
Thank you for the quick review! I'll post the rebased change soon. Hope it becomes a little smaller.
--
To view, visit http://gerrit.cloudera.org:8080/24058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied342a3b89eb922137f0c1a7d3b2978b813de381
Gerrit-Change-Number: 24058
Gerrit-PatchSet: 3
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2026 12:42:05 +0000
Gerrit-HasComments: No