You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by alourie <gi...@git.apache.org> on 2017/04/10 01:55:15 UTC
[GitHub] zeppelin pull request #2238: 0.7.1 with ssl
GitHub user alourie opened a pull request:
https://github.com/apache/zeppelin/pull/2238
0.7.1 with ssl
### What is this PR for?
The Cassandra Interpreter does not support talking to clusters that use SSL/client to node encryption. It does not have the properties needed to configure the SSL Context. This PR adds the properties to the driver config and sets up the SSL options when they are requested.
### What type of PR is it?
Feature
### What is the Jira issue?
[ZEPPELIN-1501](https://issues.apache.org/jira/browse/ZEPPELIN-1501)
### How should this be tested?
Using Cassandra/CQL interpreter connect to a Cassandra cluster that uses a client to node encryption, i.e:
```
%cassandra
describe keyspaces;
```
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes.
The new SSL-related properties should be added to the list (cassandra.ssl.enabled, cassandra.ssl.truststore.path and cassandra.ssl.truststore.password).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/instaclustr/zeppelin 0.7.1-withSSL
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2238
----
commit 521b2d9439277605c957f29e8ba1832ab5a6b4b9
Author: Robert Marshall <ro...@instaclustrs-macbook-pro.local>
Date: 2016-09-18T23:41:23Z
Add SSL support to Cassandra interpreter
commit 1ea328b17dd4ae1dffc06b4be0e37e02886fd41c
Author: Alex Lourie <dj...@gmail.com>
Date: 2017-04-10T01:42:23Z
Simplify const
Signed-off-by: Alex Lourie <dj...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2238
Thanks @alourie for the contribution
Could you configure CI? Following message from Jekins might help.
```
Looks like travis-ci is not configured for your fork.
Please setup by swich on 'zeppelin' repository at https://travis-ci.org/profile and travis-ci.
And then make sure 'Build branch updates' option is enabled in the settings https://travis-ci.org/instaclustr/zeppelin/settings.
To trigger CI after setup, you will need ammend your last commit with
git commit --amend
git push your-remote HEAD --force
See http://zeppelin.apache.org/contribution/contributions.html#continuous-integration.
Build step 'Execute shell' marked build as failure
```
Let me know if you have any problem on setting up CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2238
LGTM. Merge this PR to master if no further discussions.
@alourie Could you let me know your JIRA id? i'd like to mark https://issues.apache.org/jira/browse/ZEPPELIN-1501 resolved with your id as assignee.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by instaclustr-oss <gi...@git.apache.org>.
Github user instaclustr-oss commented on the issue:
https://github.com/apache/zeppelin/pull/2238
Hi @Leemoonsoo
Sorry for taking awhile to setup the CI. Now that I have, I see some jobs fail. What should I do about it?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2238
Thanks @alourie and Rob Marshall.
This PR has merged. but @asfgit didn't automatically closed it. @alourie Could you close this PR manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by alourie <gi...@git.apache.org>.
Github user alourie commented on the issue:
https://github.com/apache/zeppelin/pull/2238
@Leemoonsoo I've tried to rerun them few times. Only one now fails - build #4; fails with NPE in C* setup/tearDown:
```Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 40.224 sec <<< FAILURE! - in org.apache.zeppelin.cassandra.CassandraInterpreterTest
org.apache.zeppelin.cassandra.CassandraInterpreterTest Time elapsed: 40.218 sec <<< ERROR!
java.lang.NullPointerException: null
at org.apache.zeppelin.cassandra.CassandraInterpreter.open(CassandraInterpreter.java:200)
at org.apache.zeppelin.cassandra.CassandraInterpreterTest.setUp(CassandraInterpreterTest.java:115)
org.apache.zeppelin.cassandra.CassandraInterpreterTest Time elapsed: 40.219 sec <<< ERROR!
java.lang.NullPointerException: null
at org.apache.zeppelin.cassandra.CassandraInterpreter.close(CassandraInterpreter.java:235)
at org.apache.zeppelin.cassandra.CassandraInterpreterTest.tearDown(CassandraInterpreterTest.java:120)
```
There's no much more information beyond that. Anything else I could do to move this forward?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by alourie <gi...@git.apache.org>.
Github user alourie commented on the issue:
https://github.com/apache/zeppelin/pull/2238
@Leemoonsoo oh wow, who knew. So now it works. All checks passed :-)
Thanks for the help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by alourie <gi...@git.apache.org>.
Github user alourie commented on the issue:
https://github.com/apache/zeppelin/pull/2238
Hi @Leemoonsoo! I have it in my task list, will get to it probably next week.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2238
They might be flaky tests. Could you retry failed jobs and see if it goes green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2238: 0.7.1 with ssl
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by alourie <gi...@git.apache.org>.
Github user alourie commented on the issue:
https://github.com/apache/zeppelin/pull/2238
@Leemoonsoo my Jira ID is alourie, but please assign it to Rob Marshall, who opened the ticket. He did all the development, I just helped with the PR/CI :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2238: 0.7.1 with ssl
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2238
Looks like code need to handle null return of `getProperty(CASSANDRA_WITH_SSL)` at `org.apache.zeppelin.cassandra.CassandraInterpreter.open(CassandraInterpreter.java:200)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---