You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "kpumuk (via GitHub)" <gi...@apache.org> on 2026/04/16 23:57:06 UTC

[PR] Cleanup Adobe Flex SDK installation following AS3 library removal [thrift]

kpumuk opened a new pull request, #3404:
URL: https://github.com/apache/thrift/pull/3404

   <!-- Explain the changes in the pull request below: -->
   
   AS3 support was dropped in https://github.com/apache/thrift/pull/2329, but we still install Adobe Flex SDK in a few places. For example, it takes 654.4 MiB in 2 layers in MSVC docker (325.0 MiB downloaded archive + 329.4 MiB uncompressed).
   
   I am investigating the insane MSVC build times, a Docker image download step dominates the build with 27 minutes clock time.
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup Adobe Flex SDK installation following AS3 library removal [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk merged PR #3404:
URL: https://github.com/apache/thrift/pull/3404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup Adobe Flex SDK installation following AS3 library removal [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on code in PR #3404:
URL: https://github.com/apache/thrift/pull/3404#discussion_r3097323708


##########
build/docker/msvc/Dockerfile:
##########
@@ -80,7 +80,7 @@ RUN C:\BuildTools\Common7\Tools\VsDevCmd.bat -arch=x64 -host_arch=x64 && `
     SETX PATH "%ZLIB_ROOT%\bin;%PATH%"
 
 # Install OpenSSL 3.6.1
-ADD --checksum=sha256:8ce11c409adbd177ca627115bc697c3b66c414bb36175ebb375341eb426894a8 https://slproweb.com/download/Win64OpenSSL-3_6_1.exe C:\TEMP\openssl.exe
+ADD --checksum=sha256:c395482a1af33b2cdd4b801b227c864ed049e0f6aff79413d31b4fa916a67b1a https://slproweb.com/download/Win64OpenSSL-3_6_2.exe C:\TEMP\openssl.exe

Review Comment:
   ```
   ADD failed: failed to GET https://slproweb.com/download/Win64OpenSSL-3_6_1.exe with status 404 Not Found: <html>
   <head><title>404 Not Found</title></head>
   <body>
   <center><h1>404 Not Found</h1></center>
   <hr><center>nginx/1.26.0</center>
   </body>
   </html>
   ```
   
   https://github.com/slproweb/opensslhashes/commit/8c3f3954c8f6eb168a8bb82dca3fd4aaf08d030e



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup Adobe Flex SDK installation following AS3 library removal [thrift]

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3404:
URL: https://github.com/apache/thrift/pull/3404#issuecomment-4271349527

   > I will be honest, have zero clue how the image gets built :-) I see it can't be found and the hash changed https://github.com/kpumuk/thrift/actions/runs/24540103116/job/71743853687
   > 
   > @Jens-G any thoughts?
   
   https://github.com/kpumuk/thrift/actions/runs/24540103116/workflow thats the workflow file used for that run. These yaml files live under .github in the source tree. Does that answer the question?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup Adobe Flex SDK installation following AS3 library removal [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on PR #3404:
URL: https://github.com/apache/thrift/pull/3404#issuecomment-4264234363

   I will be honest, have zero clue how the image gets built :-) I see it can't be found and the hash changed https://github.com/kpumuk/thrift/actions/runs/24540103116/job/71743853687
   
   @Jens-G any thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup Adobe Flex SDK installation following AS3 library removal [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on PR #3404:
URL: https://github.com/apache/thrift/pull/3404#issuecomment-4274047029

   msvc-d5d97583f97d is 9,511,267,796 bytes total compressed registry size (8.858 GiB, 37 layers). msvc-cfc34fb57460 is 10,224,959,428 bytes (9.523 GiB, 39 layers). Net: d5... is smaller by 713,691,632 bytes (680.6 MiB). The main size win is removal of Adobe Flex from the older Dockerfile; that saves 654.4 MiB by itself, partially offset by a larger refreshed parent image layer.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup Adobe Flex SDK installation following AS3 library removal [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on PR #3404:
URL: https://github.com/apache/thrift/pull/3404#issuecomment-4264274464

   Looks like it might be caused by the fact I run it from my fork, which does not have ghcr and so the error is "manifest unknown"...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup Adobe Flex SDK installation following AS3 library removal [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on PR #3404:
URL: https://github.com/apache/thrift/pull/3404#issuecomment-4271506443

   > https://github.com/kpumuk/thrift/actions/runs/24540103116/workflow thats the workflow file used for that run. These yaml files live under .github in the source tree. Does that answer the question?
   
   Yeah. I figured it was breaking because the error was different from what the script expected :-) Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org