You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zorrofox (via GitHub)" <gi...@apache.org> on 2023/03/31 14:12:33 UTC
[GitHub] [incubator-seatunnel] zorrofox opened a new pull request, #4468: [Improve][AWS] update the bundle aws sdk version to 1.11.1034
zorrofox opened a new pull request, #4468:
URL: https://github.com/apache/incubator-seatunnel/pull/4468
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
The new AWS JAVA SDK version support more hadoop-aws auth method like EC2 profile [IMDSv2](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html) and [WebIdentityTokenCredentialsProvider.](https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-core/src/main/java/com/amazonaws/auth/WebIdentityTokenCredentialsProvider.java) which will ensure AWS S3 access in EC2 IMDSv2 only and [EKS IRSA](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html).
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [x] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [x] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4468: [Improve][AWS] update the bundle aws sdk version to 1.11.1034
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4468:
URL: https://github.com/apache/incubator-seatunnel/pull/4468#issuecomment-1502090682
> > Yes, I think `1.11.1034` is good. Please add e2e for this pr.
> > You can add an e2e test case and run it in your local env. And then put the picture of the result here. Before you push the e2e code, you need add `@Disable` annotation for it.
>
> Sorry I am not very familiar this project code base, how to write e2e testing code? I find several folders in [seatunnel-e2e](https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e) which should I create the testing code class? Or should I pick up a Connector such as S3File to write the testing code?
reference
https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zorrofox commented on pull request #4468: [Improve][AWS] update the bundle aws sdk version to 1.11.1034
Posted by "zorrofox (via GitHub)" <gi...@apache.org>.
zorrofox commented on PR #4468:
URL: https://github.com/apache/incubator-seatunnel/pull/4468#issuecomment-1492856983
> Yes, I think `1.11.1034` is good. Please add e2e for this pr.
>
> You can add an e2e test case and run it in your local env. And then put the picture of the result here. Before you push the e2e code, you need add `@Disable` annotation for it.
Sorry I am not very familiar this project code base, how to write e2e testing code? I find several folders in [seatunnel-e2e](https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e) which should I create the testing code class? Or should I pick up a Connector such as S3File to write the testing code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org