You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ja...@apache.org on 2020/08/17 03:00:37 UTC
svn commit: r1880914 - /subversion/branches/1.14.x/STATUS
Author: jamessan
Date: Mon Aug 17 03:00:37 2020
New Revision: 1880914
URL: http://svn.apache.org/viewvc?rev=1880914&view=rev
Log:
* STATUS:
Vote +1 on the 1.14.x-r1880374-fsfs branch, approving.
Vote +1 on r1880886.
Modified:
subversion/branches/1.14.x/STATUS
Modified: subversion/branches/1.14.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1880914&r1=1880913&r2=1880914&view=diff
==============================================================================
--- subversion/branches/1.14.x/STATUS (original)
+++ subversion/branches/1.14.x/STATUS Mon Aug 17 03:00:37 2020
@@ -32,24 +32,25 @@ Candidate changes:
Votes:
+1: julianfoad, hartmannathan
- * r1880374:subversion/libsvn_fs_fs
- Fix an uninitialized read in svn_fs_fs__index_append().
- Justification:
- Uninitialized reads are potentially undefined behaviour.
- Branch:
- 1.14.x-r1880374-fsfs
- Votes:
- +1: danielsh, hartmannathan
-
* r1880886
Fix crash in JavaHL JNI wrapper caused by object lifetimes
Justification:
Fixes a crash encountered with GCC 10.
Votes:
- +1: hartmannathan
+ +1: hartmannathan, jamessan
Veto-blocked changes:
=====================
Approved changes:
=================
+
+ * r1880374:subversion/libsvn_fs_fs
+ Fix an uninitialized read in svn_fs_fs__index_append().
+ Justification:
+ Uninitialized reads are potentially undefined behaviour.
+ Branch:
+ 1.14.x-r1880374-fsfs
+ Votes:
+ +1: danielsh, hartmannathan, jamessan
+
Re: svn commit: r1880914 - /subversion/branches/1.14.x/STATUS
Posted by James McCoy <ja...@jamessan.com>.
On Mon, Aug 17, 2020 at 08:13:25AM +0000, Daniel Shahaf wrote:
> jamessan@apache.org wrote on Mon, 17 Aug 2020 03:00 -0000:
> > +++ subversion/branches/1.14.x/STATUS Mon Aug 17 03:00:37 2020
> > @@ -32,24 +32,25 @@ Candidate changes:
> > * r1880886
> > Fix crash in JavaHL JNI wrapper caused by object lifetimes
> > Justification:
> > Fixes a crash encountered with GCC 10.
> > Votes:
> > - +1: hartmannathan
> > + +1: hartmannathan, jamessan
>
> Any reason not to move this to approved, James? Bindings changes
> require two votes.
Only that I never remember what the voting requirements are, so I
default to 3 unless I happen to look up the rules.
Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
Re: svn commit: r1880914 - /subversion/branches/1.14.x/STATUS
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
jamessan@apache.org wrote on Mon, 17 Aug 2020 03:00 -0000:
> +++ subversion/branches/1.14.x/STATUS Mon Aug 17 03:00:37 2020
> @@ -32,24 +32,25 @@ Candidate changes:
> * r1880886
> Fix crash in JavaHL JNI wrapper caused by object lifetimes
> Justification:
> Fixes a crash encountered with GCC 10.
> Votes:
> - +1: hartmannathan
> + +1: hartmannathan, jamessan
Any reason not to move this to approved, James? Bindings changes
require two votes.
Cheers,
Daniel
Re: svn commit: r1880914 - /subversion/branches/1.14.x/STATUS
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
jamessan@apache.org wrote on Mon, 17 Aug 2020 03:00 -0000:
> +++ subversion/branches/1.14.x/STATUS Mon Aug 17 03:00:37 2020
> @@ -32,24 +32,25 @@ Candidate changes:
> * r1880886
> Fix crash in JavaHL JNI wrapper caused by object lifetimes
> Justification:
> Fixes a crash encountered with GCC 10.
> Votes:
> - +1: hartmannathan
> + +1: hartmannathan, jamessan
Any reason not to move this to approved, James? Bindings changes
require two votes.
Cheers,
Daniel