You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/23 15:03:58 UTC
[GitHub] [incubator-nuttx-testing] ramya-n-s opened a new pull request #66: Added renesas precheck
ramya-n-s opened a new pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66
## Summary
Added renesas pre-check for RX65N
cibuild.sh: Textinfo issue for RX toolchain compilation resolved
## Impact
To enable the renesas pre-check
## Testing
Tested RX toolchain compilation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66#discussion_r495715863
##########
File path: cibuild.sh
##########
@@ -234,7 +234,8 @@ function rx-gcc-toolchain {
if [ ! -f "$prebuilt/renesas-toolchain/rx-elf-gcc/bin/rx-elf-gcc" ]; then
case $os in
Linux)
Review comment:
I have been think about to add option into datalist to filter out some build from the specific OS, something like this:
```
/renesas/rx65n/rx65n-grrose, linux
```
so we can get the fine-grained control.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] ramya-n-s commented on a change in pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
ramya-n-s commented on a change in pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66#discussion_r495724796
##########
File path: testlist/all.dat
##########
@@ -30,3 +30,9 @@
/x86_64
/xtensa
+
+/renesas/rx65n/rx65n-grrose
+-rx65n-grrose:ipv6
Review comment:
Modified the defconfig file for ipv6 configuration. The testing of the modification is not done yet. Once the testing is completed, we will raise a PR to push the defconfig and then enable ipv6 build in precheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] patacongo commented on a change in pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66#discussion_r495600661
##########
File path: cibuild.sh
##########
@@ -234,7 +234,8 @@ function rx-gcc-toolchain {
if [ ! -f "$prebuilt/renesas-toolchain/rx-elf-gcc/bin/rx-elf-gcc" ]; then
case $os in
Linux)
Review comment:
With Windows Cygwin I think most people use https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm
There are lots of other Windows native toolchains.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66#discussion_r495600986
##########
File path: cibuild.sh
##########
@@ -234,7 +234,8 @@ function rx-gcc-toolchain {
if [ ! -f "$prebuilt/renesas-toolchain/rx-elf-gcc/bin/rx-elf-gcc" ]; then
case $os in
Linux)
Review comment:
But that does not have the rx support and Renesas like Microchip have the binary releases behind a login which is really annoying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66#discussion_r495588736
##########
File path: testlist/all.dat
##########
@@ -30,3 +30,9 @@
/x86_64
/xtensa
+
+/renesas/rx65n/rx65n-grrose
+-rx65n-grrose:ipv6
Review comment:
why remove ipv6 from build?
##########
File path: cibuild.sh
##########
@@ -234,7 +234,8 @@ function rx-gcc-toolchain {
if [ ! -f "$prebuilt/renesas-toolchain/rx-elf-gcc/bin/rx-elf-gcc" ]; then
case $os in
Linux)
Review comment:
Should we add Darwin and merge renesas into avr-mips-riscv-x86-xtensa?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66#discussion_r495717324
##########
File path: cibuild.sh
##########
@@ -234,7 +234,8 @@ function rx-gcc-toolchain {
if [ ! -f "$prebuilt/renesas-toolchain/rx-elf-gcc/bin/rx-elf-gcc" ]; then
case $os in
Linux)
Review comment:
Could be nice. That way we could also enable some of the sim builds that are blocked because they don't support macOS.
In the meantime can we just leave this as the additional target and then reshuffle them once we have the feature?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66#discussion_r495596394
##########
File path: cibuild.sh
##########
@@ -234,7 +234,8 @@ function rx-gcc-toolchain {
if [ ! -f "$prebuilt/renesas-toolchain/rx-elf-gcc/bin/rx-elf-gcc" ]; then
case $os in
Linux)
Review comment:
That will require building gcc on mac every build which we probably don't want same with windows. I thinking we probably need a pipeline for building these tool chains and uploading them to S3 or something. I want that functionally for doing the bloaty stuff anyway. Are you fine just kicking this down the road a bit? It should still finish before the Mac worker anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #66: Added renesas precheck
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #66:
URL: https://github.com/apache/incubator-nuttx-testing/pull/66#discussion_r495774530
##########
File path: cibuild.sh
##########
@@ -234,7 +234,8 @@ function rx-gcc-toolchain {
if [ ! -f "$prebuilt/renesas-toolchain/rx-elf-gcc/bin/rx-elf-gcc" ]; then
case $os in
Linux)
Review comment:
Sure, let's go ahead merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org