You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/06/10 01:50:47 UTC

[GitHub] [trafficserver] masaori335 opened a new issue #6877: ⛱️ Refactoring closing HTTP/2 session

masaori335 opened a new issue #6877:
URL: https://github.com/apache/trafficserver/issues/6877


   There are too many paths to close/free Http2ClientSession/Http2ConnectionState. I know this is result of fixing bunch of issues step by step in the past. However, having similar name functions and call them each other doesn't make sense and it making us hard to find bugs.
   
   ## Notes
   - The order of SSN/TXN close hook is a matter (#6364, #787)
   - `vc->add_to_keep_alive_queue()` call could be pitfall (https://github.com/apache/trafficserver/issues/4504#issuecomment-460917346)
   
   ## TODOs
   - [ ] Rename `Http2ConnectionState::release_stream()` because the name doesn't describe what the function does
   - [ ] Design how to close Http2ClientSession/Http2ConnectionState simply


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on issue #6877: ⛱️ Refactoring closing HTTP/2 session

Posted by GitBox <gi...@apache.org>.
masaori335 commented on issue #6877:
URL: https://github.com/apache/trafficserver/issues/6877#issuecomment-865483055


   #7845 covers this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 closed issue #6877: ⛱️ Refactoring closing HTTP/2 session

Posted by GitBox <gi...@apache.org>.
masaori335 closed issue #6877:
URL: https://github.com/apache/trafficserver/issues/6877


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit commented on issue #6877: ⛱️ Refactoring closing HTTP/2 session

Posted by GitBox <gi...@apache.org>.
maskit commented on issue #6877:
URL: https://github.com/apache/trafficserver/issues/6877#issuecomment-641681568


   Removing Http2ConnectionState (moving its functions into H2Ssn/Txn) would make things much easier.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] github-actions[bot] commented on issue #6877: ⛱️ Refactoring closing HTTP/2 session

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #6877:
URL: https://github.com/apache/trafficserver/issues/6877#issuecomment-864211405


   This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on issue #6877: ⛱️ Refactoring closing HTTP/2 session

Posted by GitBox <gi...@apache.org>.
masaori335 commented on issue #6877:
URL: https://github.com/apache/trafficserver/issues/6877#issuecomment-865483055


   #7845 covers this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 closed issue #6877: ⛱️ Refactoring closing HTTP/2 session

Posted by GitBox <gi...@apache.org>.
masaori335 closed issue #6877:
URL: https://github.com/apache/trafficserver/issues/6877


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org