You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by lukasz-antoniak <gi...@git.apache.org> on 2018/11/22 22:32:37 UTC

[GitHub] bahir pull request #70: [BAHIR-182] Spark Streaming PubNub connector

GitHub user lukasz-antoniak opened a pull request:

    https://github.com/apache/bahir/pull/70

    [BAHIR-182] Spark Streaming PubNub connector

    JIRA ticket: https://issues.apache.org/jira/browse/BAHIR-182.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukasz-antoniak/bahir BAHIR-182

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #70
    
----
commit 34f7ce5342f7875bbea1afeca3bca84a445bb959
Author: Lukasz Antoniak <lu...@...>
Date:   2018-11-22T22:28:44Z

    [BAHIR-182] Spark Streaming PubNub connector

----


---

[GitHub] bahir issue #70: [BAHIR-182] Spark Streaming PubNub connector

Posted by lresende <gi...@git.apache.org>.

Github user lresende commented on the issue:

    https://github.com/apache/bahir/pull/70
  
    @lukasz-antoniak LGTM.
    
    As for the build failure, I did run it successfully on my local machine with the Oracle JDK..., could you please force a new build to make sure all things are ok... 


---

[GitHub] bahir issue #70: [BAHIR-182] Spark Streaming PubNub connector

Posted by lukasz-antoniak <gi...@git.apache.org>.

Github user lukasz-antoniak commented on the issue:

    https://github.com/apache/bahir/pull/70
  
    Thank you for quick verification. I have created module README and updated README from project root directory to correctly reference all modules in alphabetical order.


---

[GitHub] bahir pull request #70: [BAHIR-182] Spark Streaming PubNub connector

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/bahir/pull/70


---

[GitHub] bahir issue #70: [BAHIR-182] Spark Streaming PubNub connector

Posted by lresende <gi...@git.apache.org>.

Github user lresende commented on the issue:

    https://github.com/apache/bahir/pull/70
  
    @lukasz-antoniak Could you please add a readme.md that documents the new extension which is used to generate the extension documentation on the website.


---