[GitHub] davisp commented on a change in pull request #476: Couchdb 3376 fix mem3 shards

[gi...@git.apache.org]

davisp commented on a change in pull request #476: Couchdb 3376 fix mem3 shards
URL: https://github.com/apache/couchdb/pull/476#discussion_r111780016
 
 

 ##########
 File path: src/mem3/src/mem3_shards.erl
 ##########
 @@ -320,8 +360,20 @@ load_shards_from_disk(DbName) when is_binary(DbName) ->
 load_shards_from_db(#db{} = ShardDb, DbName) ->
     case couch_db:open_doc(ShardDb, DbName, [ejson_body]) of
     {ok, #doc{body = {Props}}} ->
+        Seq = couch_db:get_update_seq(ShardDb),
         Shards = mem3_util:build_ordered_shards(DbName, Props),
-        gen_server:cast(?MODULE, {cache_insert, DbName, Shards}),
+        case maybe_spawn_shard_writer(DbName, Shards) of
 
 Review comment:
   I'm not seeing where we link the writer.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services