You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/17 03:47:29 UTC
[GitHub] [iotdb] cmlmakahts opened a new pull request, #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
cmlmakahts opened a new pull request, #7032:
URL: https://github.com/apache/iotdb/pull/7032
Add a option "tp" to indicate timestamp precision (ms/ns/us)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
Posted by GitBox <gi...@apache.org>.
cmlmakahts commented on code in PR #7032:
URL: https://github.com/apache/iotdb/pull/7032#discussion_r948606465
##########
cli/pom.xml:
##########
@@ -45,7 +45,6 @@
<artifactId>iotdb-server</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
- <scope>test</scope>
Review Comment:
Using shade plugin shaded DatetimeUtils.class into iotdb-client.jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7032:
URL: https://github.com/apache/iotdb/pull/7032#discussion_r948734549
##########
docs/UserGuide/Write-And-Delete-Data/CSV-Tool.md:
##########
@@ -174,9 +174,9 @@ Time,Device,str(TEXT),int(INT32)
```shell
# Unix/OS X
-> tools/import-csv.sh -h <ip> -p <port> -u <username> -pw <password> -f <xxx.csv> [-fd <./failedDirectory>] [-aligned <true>]
+> tools/import-csv.sh -h <ip> -p <port> -u <username> -pw <password> -f <xxx.csv> [-fd <./failedDirectory>] [-aligned <true>] [-tp <ms/ns/us>]
# Windows
-> tools\import-csv.bat -h <ip> -p <port> -u <username> -pw <password> -f <xxx.csv> [-fd <./failedDirectory>] [-aligned <true>]
+> tools\import-csv.bat -h <ip> -p <port> -u <username> -pw <password> -f <xxx.csv> [-fd <./failedDirectory>] [-aligned <true>] [-tp <ms/ns/us>]
Review Comment:
Update Chinese user guide as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a diff in pull request #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on code in PR #7032:
URL: https://github.com/apache/iotdb/pull/7032#discussion_r947836547
##########
cli/pom.xml:
##########
@@ -45,7 +45,6 @@
<artifactId>iotdb-server</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
- <scope>test</scope>
Review Comment:
The client cannot directly import iotdb-server and jar. need deal...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
Posted by GitBox <gi...@apache.org>.
cmlmakahts commented on code in PR #7032:
URL: https://github.com/apache/iotdb/pull/7032#discussion_r948606242
##########
cli/src/main/java/org/apache/iotdb/tool/ImportCsv.java:
##########
@@ -82,6 +82,9 @@ public class ImportCsv extends AbstractCsvTool {
private static final String CSV_SUFFIXS = "csv";
private static final String TXT_SUFFIXS = "txt";
+ private static final String TIMESTAMP_PRECISION_ARGS = "tp";
+ private static final String TIMESTAMP_PRECISION_NAME = "timestamp precision (ms/us/ns)";
+
Review Comment:
User guide is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7032:
URL: https://github.com/apache/iotdb/pull/7032#discussion_r947564883
##########
cli/src/main/java/org/apache/iotdb/tool/ImportCsv.java:
##########
@@ -82,6 +82,9 @@ public class ImportCsv extends AbstractCsvTool {
private static final String CSV_SUFFIXS = "csv";
private static final String TXT_SUFFIXS = "txt";
+ private static final String TIMESTAMP_PRECISION_ARGS = "tp";
+ private static final String TIMESTAMP_PRECISION_NAME = "timestamp precision (ms/us/ns)";
+
Review Comment:
Consider updating the user guide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
Posted by GitBox <gi...@apache.org>.
HTHou commented on PR #7032:
URL: https://github.com/apache/iotdb/pull/7032#issuecomment-1218988493
Some tests failed, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
Posted by GitBox <gi...@apache.org>.
cmlmakahts commented on code in PR #7032:
URL: https://github.com/apache/iotdb/pull/7032#discussion_r948744238
##########
docs/UserGuide/Write-And-Delete-Data/CSV-Tool.md:
##########
@@ -174,9 +174,9 @@ Time,Device,str(TEXT),int(INT32)
```shell
# Unix/OS X
-> tools/import-csv.sh -h <ip> -p <port> -u <username> -pw <password> -f <xxx.csv> [-fd <./failedDirectory>] [-aligned <true>]
+> tools/import-csv.sh -h <ip> -p <port> -u <username> -pw <password> -f <xxx.csv> [-fd <./failedDirectory>] [-aligned <true>] [-tp <ms/ns/us>]
# Windows
-> tools\import-csv.bat -h <ip> -p <port> -u <username> -pw <password> -f <xxx.csv> [-fd <./failedDirectory>] [-aligned <true>]
+> tools\import-csv.bat -h <ip> -p <port> -u <username> -pw <password> -f <xxx.csv> [-fd <./failedDirectory>] [-aligned <true>] [-tp <ms/ns/us>]
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #7032: [IOTDB-4156] import csv has error time after timestamp_precision set ns
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7032:
URL: https://github.com/apache/iotdb/pull/7032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org