You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Chris A. Mattmann (JIRA)" <ji...@apache.org> on 2011/01/23 18:57:43 UTC

[jira] Commented: (OODT-98) Resource Manager TestXmlQueueRepository test fails on some computers because .keySet() order is undefined

    [ https://issues.apache.org/jira/browse/OODT-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985382#action_12985382 ] 

Chris A. Mattmann commented on OODT-98:
---------------------------------------

The existing fix to this didn't work for me on Tumor one of our EDRN machines:

{noformat}
[mattmann@tumor oodt0.2]$ uname -a
Linux tumor2.6.18-194.3.1.el5 #1 SMP Thu May 13 13:08:30 EDT 2010 x86_64 x86_64 x86_64 GNU/Linux
[mattmann@tumor oodt0.2]$ java -version
java version "1.5.0_14"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_14-b03)
Java HotSpot(TM) Server VM (build 1.5.0_14-b03, mixed mode)
[mattmann@tumor oodt0.2]$ 
{noformat}

Here was the error I got:

{noformat}
[mattmann@tumor oodt0.2]$ more resource/target/surefire-reports/org.apache.oodt.cas.resource.queuerepo.TestXmlQueueRepository.txt 
-------------------------------------------------------------------------------
Test set: org.apache.oodt.cas.resource.queuerepo.TestXmlQueueRepository
-------------------------------------------------------------------------------
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.23 sec <<< FAILURE!
testMapping(org.apache.oodt.cas.resource.queuerepo.TestXmlQueueRepository)  Time elapsed: 0.207 sec  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<[high, quick, long]> but was:<[quick, high, long]>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:280)
	at junit.framework.Assert.assertEquals(Assert.java:64)
	at junit.framework.Assert.assertEquals(Assert.java:71)
	at org.apache.oodt.cas.resource.queuerepo.TestXmlQueueRepository.testMapping(TestXmlQueueRepository.java:52)

{noformat}

This is b/c there is still a piece of this unit tests that needs the containsAll patch that Brian did. I'll commit a fix for this shortly.

> Resource Manager TestXmlQueueRepository test fails on some computers because <hashmap>.keySet() order is undefined
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: OODT-98
>                 URL: https://issues.apache.org/jira/browse/OODT-98
>             Project: OODT
>          Issue Type: Bug
>          Components: resource manager
>    Affects Versions: 0.1-incubating
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.2
>
>         Attachments: OODT-98.2010-12-20.patch.txt
>
>
> In TestXmlQueueRepository's testMapping(), the following line:
> {noformat}
> assertEquals(this.queueManager.getQueues("localhost"), Arrays.asList("quick", "high", "long"));
> {noformat}
> should be:
> {noformat}
> assertTrue(this.queueManager.getQueues("localhost").containsAll(Arrays.asList("quick", "high", "long")));
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.