You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/28 07:00:31 UTC

[jira] [Commented] (CB-9887) Windows platform file plugin does not define standard cordova.file.* paths

    [ https://issues.apache.org/jira/browse/CB-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977810#comment-14977810 ] 

ASF GitHub Bot commented on CB-9887:
------------------------------------

GitHub user ghenry22 opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/143

    CB-9887 cordova.file.* paths for windows platform

    Update the plugin to define cordova.file.* paths for windows platform as appropriate.
    
    Documentation updated to show where to store things.
    
    Have tested this in my own app and the paths are detected as file plugin works as expected now.
    
    Means you can use cordova.file.dataDirectory in your app and then run that app on ios, android, windows with consistent behaviour without requiring platform specific code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ghenry22/cordova-plugin-file windows_paths

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 34a66b89d3e6b9f3c4c43b95adcd60227d2cdc19
Author: ghenry22 <gh...@gmail.com>
Date:   2015-10-28T04:55:14Z

    Add windows paths to cordova.file object
    
    add standard paths to cordova.file object for windows.  Standardises
    behaviour for windows platform and resolves cordova.file is undefined
    errors.

commit 1e4094a2b40f5803f9954bcd3f15664e471c12d4
Author: ghenry22 <gh...@gmail.com>
Date:   2015-10-28T05:01:57Z

    fix

commit d7c0b0beb641a4db51a94235768e0c1873e9f6aa
Author: ghenry22 <gh...@gmail.com>
Date:   2015-10-28T05:37:49Z

    update docs for windows platform details

commit 442973f2646f5767b84dc1e57dc5244afba7db84
Author: ghenry22 <gh...@gmail.com>
Date:   2015-10-28T05:40:34Z

    fix docs formatting

commit 03d9d32a28c0884fe61c16f4f976d9114c316ef7
Author: ghenry22 <gh...@gmail.com>
Date:   2015-10-28T05:42:00Z

    fix docs

----


> Windows platform file plugin does not define standard cordova.file.* paths
> --------------------------------------------------------------------------
>
>                 Key: CB-9887
>                 URL: https://issues.apache.org/jira/browse/CB-9887
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>         Environment: cordova platform windows
> windows 10 universal app
>            Reporter: Gaven Henry
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> On android and ios the file plugin defines some standard paths of the form "cordova.file.*" (such as cordova.file.dataDirectory) which are used as a simple and consistent way to access different types of storage.
> On the windows platform none of these paths are defined and attempts to query cordova.file.* returns undefined.
> This means that if you want to port an app from ios or android to the windows platform it will fail to launch due to these paths not being defined.
> Need to update the windows platform code to define the available file systems for the windows platform.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org