You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "stillalex (via GitHub)" <gi...@apache.org> on 2025/01/24 15:22:12 UTC
[PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
stillalex opened a new pull request, #3112:
URL: https://github.com/apache/solr/pull/3112
https://issues.apache.org/jira/browse/SOLR-13360
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #3112:
URL: https://github.com/apache/solr/pull/3112#issuecomment-2872800156
ping @jdyer1 who used to exclusively work on spellcheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on code in PR #3112:
URL: https://github.com/apache/solr/pull/3112#discussion_r1975402160
##########
solr/core/src/java/org/apache/solr/spelling/SpellCheckCollator.java:
##########
@@ -51,6 +51,14 @@ public class SpellCheckCollator {
private boolean suggestionsMayOverlap = false;
private int docCollectionLimit = 0;
+ private static volatile boolean mergeSpellCheckCorrections =
+ Boolean.parseBoolean(
+ System.getProperty("solr.SpellCheckCollator.mergeSpellCheckCorrections", "true"));
+
+ private static volatile boolean logSIOOBEDebugData =
Review Comment:
sounds good @anshumg! removed that property and moved the entire things into a debug log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on PR #3112:
URL: https://github.com/apache/solr/pull/3112#issuecomment-2824151086
@anshumg any other thoughts on the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
Posted by "anshumg (via GitHub)" <gi...@apache.org>.
anshumg commented on code in PR #3112:
URL: https://github.com/apache/solr/pull/3112#discussion_r1973916671
##########
solr/core/src/java/org/apache/solr/spelling/SpellCheckCollator.java:
##########
@@ -51,6 +51,14 @@ public class SpellCheckCollator {
private boolean suggestionsMayOverlap = false;
private int docCollectionLimit = 0;
+ private static volatile boolean mergeSpellCheckCorrections =
+ Boolean.parseBoolean(
+ System.getProperty("solr.SpellCheckCollator.mergeSpellCheckCorrections", "true"));
+
+ private static volatile boolean logSIOOBEDebugData =
Review Comment:
This seems like an unrelated change.
Can we just add a debug line and switch the log level for the specific class instead of relying on a system property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3112:
URL: https://github.com/apache/solr/pull/3112#issuecomment-3064321571
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3112:
URL: https://github.com/apache/solr/pull/3112#issuecomment-3272735596
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3112: SOLR-13360 StringIndexOutOfBoundsException: String index out of range
URL: https://github.com/apache/solr/pull/3112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org