You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/01 16:47:08 UTC

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1957: feat: added husky for pre-commit

liuxiran commented on pull request #1957:
URL: https://github.com/apache/apisix-dashboard/pull/1957#issuecomment-872398802


   I tried in my local env, and found that when I tried to commit a `js` file e.g. cypress test files or `.eslintrc.js`, an error will occur:
   
   ![image](https://user-images.githubusercontent.com/2561857/124159161-67d38b80-dacd-11eb-8391-a477dff2d4f3.png)
   
   That is because we did not put these js files into `tsconfig.json` include list, or we can also choose to ignore them
   
   I suggest to put `cypress` into include list, as for other config files like `.eslintrc.js`, we can put them into `.eslintignore` file
   
   what do you think?
   
   cc @juzhiyuan @guoqqqi @iamayushdas @LiteSun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org