[GitHub] [spark] cloud-fan commented on a change in pull request #35541: [SPARK-38229][SQL] Should't check temp/external/ifNotExists with visitReplaceTable when parser

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35541:
URL: https://github.com/apache/spark/pull/35541#discussion_r812638358



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2945,9 +2945,9 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
    * Validate a replace table statement and return the [[TableIdentifier]].
    */
   override def visitReplaceTableHeader(
-      ctx: ReplaceTableHeaderContext): TableHeader = withOrigin(ctx) {
+      ctx: ReplaceTableHeaderContext): Seq[String] = withOrigin(ctx) {

Review comment:
       Can we further clean it up? Now this method simply parses the table name, and we don't need to have a `visitReplaceTableHeader` method for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org