You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by Stephen Mallette <sp...@gmail.com> on 2018/04/26 23:29:25 UTC

.NET NamingConversions Template

I just noticed that the NamingConversions.template

https://github.com/apache/tinkerpop/blob/2c373064021c9df5cf02906e73bdb9f37d6c9d6c/gremlin-dotnet/glv/NamingConversions.template

Doesn't appear to be referenced in the groovy script for some reason:

https://github.com/apache/tinkerpop/blob/2c373064021c9df5cf02906e73bdb9f37d6c9d6c/gremlin-dotnet/glv/generate.groovy

Was that an oversight of some sort?

AW: .NET NamingConversions Template

Posted by Florian Hockmann <fh...@florian-hockmann.de>.
Oh yes, looks like I forgot to remove the template when I transformed the enums into classes for Gremlin.Net. I just removed the NamingConversions.cs file and deleted the lines in the groovy script that use the template but forgot the template itself [1].

I'll push a CTR commit that also removes the template.

[1] commit: https://github.com/apache/tinkerpop/pull/815/commits/dcf3da3917a9626d432ef26089bb05c6a15158ed


-----Ursprüngliche Nachricht-----
Von: Stephen Mallette <sp...@gmail.com> 
Gesendet: Freitag, 27. April 2018 01:29
An: dev@tinkerpop.apache.org
Betreff: .NET NamingConversions Template

I just noticed that the NamingConversions.template

https://github.com/apache/tinkerpop/blob/2c373064021c9df5cf02906e73bdb9f37d6c9d6c/gremlin-dotnet/glv/NamingConversions.template

Doesn't appear to be referenced in the groovy script for some reason:

https://github.com/apache/tinkerpop/blob/2c373064021c9df5cf02906e73bdb9f37d6c9d6c/gremlin-dotnet/glv/generate.groovy

Was that an oversight of some sort?