You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/19 11:33:03 UTC

[GitHub] [flink] StephanEwen commented on pull request #13637: [FLINK-19494][DataStream API] Adjust StreamExecutionEnvironment.generateSequence() to new API Sources

StephanEwen commented on pull request #13637:
URL: https://github.com/apache/flink/pull/13637#issuecomment-712095498


   Looks good to me, in general, with a few small follow-ups:
   
     1. I think the JavaDocs for the method could be improved slightly. Maybe you can just reuse the JavaDocs from the source implementation itself? https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/api/connector/source/lib/NumberSequenceSource.java
   
     2. We should also deprecate the old method (`generateSequence()`) so that users are not confused which method to use.
   
     3. The `fromSource()` method takes the name directly as an explicit parameter. I am wondering if we should adopt that style also in the new `fromSequence()` method. @aljoscha what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org