You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Ryan Blue (JIRA)" <ji...@apache.org> on 2018/03/23 15:33:00 UTC

[jira] [Commented] (AVRO-2164) Make Decimal a first class type.

    [ https://issues.apache.org/jira/browse/AVRO-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411572#comment-16411572 ] 

Ryan Blue commented on AVRO-2164:
---------------------------------

I disagree that the current format is lossy. The decimal scale is stored in the logical type and should be uniform. I think there may be a problem where Avro doesn't reject values with the wrong scale, but that's a simple bug and not a problem.

If you want a type that stores the scale of each value with the value itself, then that's a new type of decimal that we can think about adding. But I think it should be a logical type, or else this would require an incompatible change to the format.

> Make Decimal a first class type.
> --------------------------------
>
>                 Key: AVRO-2164
>                 URL: https://issues.apache.org/jira/browse/AVRO-2164
>             Project: Avro
>          Issue Type: Improvement
>          Components: logical types
>    Affects Versions: 1.8.2
>            Reporter: Andy Coates
>            Priority: Major
>
> I'd be interested to hear the communities thoughts on making decimal a first class type. 
> The current logical type encodes a decimal into a _bytes_ or _fixed_. This encoding does not include any information about the scale, i.e. this encoding is lossy. 
> There are open issues around the compatibility / evolvability of schemas containing decimal logical types, (e.g. AVRO-2078 & AVRO-1721), that mean reading data that was previously written with a different scale will result in data corruption.
> If these issues were fixed, with suitable compatibility checks put in place, this would then make it impossible to evolve an Avro schema where the scale needs to be changed. This inability to evolve the scale is very restrictive, and can result in high overhead for organizations that _need_ to change the scale, i.e. they may potentially need to copy their entire data set, deserializing with the old scale and re-serializing with the new.
> If _decimal_ were promoted to a first class type, this would allow the scale to be captured in the serialized form, allow for schema evolution support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)