You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/09 10:03:37 UTC

[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #2240: nrf52 GPIO/GPIOTE: better expose pin interrupt capability

raiden00pl commented on a change in pull request #2240:
URL: https://github.com/apache/incubator-nuttx/pull/2240#discussion_r519687269



##########
File path: arch/arm/src/nrf52/nrf52_gpio.c
##########
@@ -204,7 +236,8 @@ int nrf52_gpio_config(nrf52_pinset_t cfgset)
       switch (cfgset & GPIO_FUNC_MASK)
         {
         case GPIO_INPUT:   /* GPIO input pin */
-          break;           /* Already configured */
+          nrf52_gpio_sense(cfgset, port, pin);

Review comment:
       This triggers GPIOTE events even if we haven't enabled pin events yet.
   As I understand, SENSE is only used for GPIOTE, then it should be configured when we enable the given pin event.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org