You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Ted Ross (JIRA)" <qp...@incubator.apache.org> on 2007/12/21 19:06:44 UTC

[jira] Created: (QPID-715) Management improvements for C++ Broker, Python API, and Python CLI

Management improvements for C++ Broker, Python API, and Python CLI
------------------------------------------------------------------

                 Key: QPID-715
                 URL: https://issues.apache.org/jira/browse/QPID-715
             Project: Qpid
          Issue Type: Improvement
          Components: C++ Broker, Python Client
         Environment: all
            Reporter: Ted Ross
            Priority: Minor


This patch provides improvements in the management CLI and brings the implementation of the broker and the python management client into compliance with the draft spec (http://cwiki.apache.org/confluence/display/qpid/Management+Design+notes).

Per-file notes:

M  python/qpid/management.py
M  cpp/src/qpid/management/ManagementAgent.h
M  cpp/src/qpid/management/ManagementAgent.cpp
M  cpp/src/qpid/management/ManagementExchange.h
M  cpp/src/qpid/management/ManagementObject.h
M  specs/management-types.xml

   Added support for new management types.
   Updated protocol to comply with draft spec in the wiki.

M  python/mgmt-cli/main.py
M  python/mgmt-cli/managementdata.py

   Lots of enhanced CLI functionality

M  cpp/src/qpid/broker/Broker.h
M  cpp/src/qpid/broker/Broker.cpp

   Added method to get the VHost object, added call to shutdown the
   management agent when the broker is destroyed.

M  cpp/src/qpid/broker/Queue.cpp

   Removed IncreaseJournalSize method (not relevant to QPID)

M  cpp/src/qpid/broker/Connection.h
M  cpp/src/qpid/broker/Connection.cpp
M  cpp/src/qpid/broker/ConnectionFactory.h
M  cpp/src/qpid/broker/ConnectionFactory.cpp
M  cpp/src/qpid/sys/ConnectionInputHandlerFactory.h
M  cpp/src/qpid/sys/AsynchIOAcceptor.cpp

   Added management for Connections (Client management class).  The
   socket is now passed to the Connection object so access can be had
   to the remote IP-address and port.

M  cpp/src/qpid/broker/SessionState.cpp
M  cpp/src/qpid/broker/SessionManager.cpp
M  cpp/src/qpid/broker/SessionState.h

   Added management for SessionState (Session management class).

M  cpp/managementgen/main.py

   Makefile fragment generation is now optional.

M  specs/management-schema.xml

   Schema updates for Client and Session.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (QPID-715) Management improvements for C++ Broker, Python API, and Python CLI

Posted by "Carl Trieloff (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Trieloff closed QPID-715.
------------------------------

    Resolution: Fixed

patch applied

> Management improvements for C++ Broker, Python API, and Python CLI
> ------------------------------------------------------------------
>
>                 Key: QPID-715
>                 URL: https://issues.apache.org/jira/browse/QPID-715
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker, Python Client
>         Environment: all
>            Reporter: Ted Ross
>            Priority: Minor
>         Attachments: qpid-patch14.diff
>
>
> This patch provides improvements in the management CLI and brings the implementation of the broker and the python management client into compliance with the draft spec (http://cwiki.apache.org/confluence/display/qpid/Management+Design+notes).
> Per-file notes:
> M  python/qpid/management.py
> M  cpp/src/qpid/management/ManagementAgent.h
> M  cpp/src/qpid/management/ManagementAgent.cpp
> M  cpp/src/qpid/management/ManagementExchange.h
> M  cpp/src/qpid/management/ManagementObject.h
> M  specs/management-types.xml
>    Added support for new management types.
>    Updated protocol to comply with draft spec in the wiki.
> M  python/mgmt-cli/main.py
> M  python/mgmt-cli/managementdata.py
>    Lots of enhanced CLI functionality
> M  cpp/src/qpid/broker/Broker.h
> M  cpp/src/qpid/broker/Broker.cpp
>    Added method to get the VHost object, added call to shutdown the
>    management agent when the broker is destroyed.
> M  cpp/src/qpid/broker/Queue.cpp
>    Removed IncreaseJournalSize method (not relevant to QPID)
> M  cpp/src/qpid/broker/Connection.h
> M  cpp/src/qpid/broker/Connection.cpp
> M  cpp/src/qpid/broker/ConnectionFactory.h
> M  cpp/src/qpid/broker/ConnectionFactory.cpp
> M  cpp/src/qpid/sys/ConnectionInputHandlerFactory.h
> M  cpp/src/qpid/sys/AsynchIOAcceptor.cpp
>    Added management for Connections (Client management class).  The
>    socket is now passed to the Connection object so access can be had
>    to the remote IP-address and port.
> M  cpp/src/qpid/broker/SessionState.cpp
> M  cpp/src/qpid/broker/SessionManager.cpp
> M  cpp/src/qpid/broker/SessionState.h
>    Added management for SessionState (Session management class).
> M  cpp/managementgen/main.py
>    Makefile fragment generation is now optional.
> M  specs/management-schema.xml
>    Schema updates for Client and Session.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (QPID-715) Management improvements for C++ Broker, Python API, and Python CLI

Posted by Ted Ross <tr...@redhat.com>.
Carl,

This is a good idea.  I'll update the schema so that there are 
cluster-specific extensions that are used only if the cluster plug-in is 
plugged in.

-Ted

Carl Trieloff wrote:
>
> Ted,
>
> Few comments/ thoughts on the patch - which is applied. I see from the 
> CLI that methods for join and leave cluster are present even
> if the cluster module is not loaded. We should probably update the 
> encapsulation so that the cluster module add's it's own data/ commands 
> to the model if loaded.
>
> The same should be true for any other plug-in that us loaded.
> Carl.
>
>
>
> Ted Ross (JIRA) wrote:
>>      [ https://issues.apache.org/jira/browse/QPID-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Ted Ross updated QPID-715:
>> --------------------------
>>
>>     Attachment: qpid-patch14.diff
>>
>> patch file
>>
>>   
>>> Management improvements for C++ Broker, Python API, and Python CLI
>>> ------------------------------------------------------------------
>>>
>>>                 Key: QPID-715
>>>                 URL: https://issues.apache.org/jira/browse/QPID-715
>>>             Project: Qpid
>>>          Issue Type: Improvement
>>>          Components: C++ Broker, Python Client
>>>         Environment: all
>>>            Reporter: Ted Ross
>>>            Priority: Minor
>>>         Attachments: qpid-patch14.diff
>>>
>>>
>>> This patch provides improvements in the management CLI and brings the implementation of the broker and the python management client into compliance with the draft spec (http://cwiki.apache.org/confluence/display/qpid/Management+Design+notes).
>>> Per-file notes:
>>> M  python/qpid/management.py
>>> M  cpp/src/qpid/management/ManagementAgent.h
>>> M  cpp/src/qpid/management/ManagementAgent.cpp
>>> M  cpp/src/qpid/management/ManagementExchange.h
>>> M  cpp/src/qpid/management/ManagementObject.h
>>> M  specs/management-types.xml
>>>    Added support for new management types.
>>>    Updated protocol to comply with draft spec in the wiki.
>>> M  python/mgmt-cli/main.py
>>> M  python/mgmt-cli/managementdata.py
>>>    Lots of enhanced CLI functionality
>>> M  cpp/src/qpid/broker/Broker.h
>>> M  cpp/src/qpid/broker/Broker.cpp
>>>    Added method to get the VHost object, added call to shutdown the
>>>    management agent when the broker is destroyed.
>>> M  cpp/src/qpid/broker/Queue.cpp
>>>    Removed IncreaseJournalSize method (not relevant to QPID)
>>> M  cpp/src/qpid/broker/Connection.h
>>> M  cpp/src/qpid/broker/Connection.cpp
>>> M  cpp/src/qpid/broker/ConnectionFactory.h
>>> M  cpp/src/qpid/broker/ConnectionFactory.cpp
>>> M  cpp/src/qpid/sys/ConnectionInputHandlerFactory.h
>>> M  cpp/src/qpid/sys/AsynchIOAcceptor.cpp
>>>    Added management for Connections (Client management class).  The
>>>    socket is now passed to the Connection object so access can be had
>>>    to the remote IP-address and port.
>>> M  cpp/src/qpid/broker/SessionState.cpp
>>> M  cpp/src/qpid/broker/SessionManager.cpp
>>> M  cpp/src/qpid/broker/SessionState.h
>>>    Added management for SessionState (Session management class).
>>> M  cpp/managementgen/main.py
>>>    Makefile fragment generation is now optional.
>>> M  specs/management-schema.xml
>>>    Schema updates for Client and Session.
>>>     
>>
>>   
>

Re: [jira] Updated: (QPID-715) Management improvements for C++ Broker, Python API, and Python CLI

Posted by Carl Trieloff <cc...@redhat.com>.
Ted,

Few comments/ thoughts on the patch - which is applied. I see from the 
CLI that methods for join and leave cluster are present even
if the cluster module is not loaded. We should probably update the 
encapsulation so that the cluster module add's it's own data/ commands 
to the model if loaded.

The same should be true for any other plug-in that us loaded.
Carl.



Ted Ross (JIRA) wrote:
>      [ https://issues.apache.org/jira/browse/QPID-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Ted Ross updated QPID-715:
> --------------------------
>
>     Attachment: qpid-patch14.diff
>
> patch file
>
>   
>> Management improvements for C++ Broker, Python API, and Python CLI
>> ------------------------------------------------------------------
>>
>>                 Key: QPID-715
>>                 URL: https://issues.apache.org/jira/browse/QPID-715
>>             Project: Qpid
>>          Issue Type: Improvement
>>          Components: C++ Broker, Python Client
>>         Environment: all
>>            Reporter: Ted Ross
>>            Priority: Minor
>>         Attachments: qpid-patch14.diff
>>
>>
>> This patch provides improvements in the management CLI and brings the implementation of the broker and the python management client into compliance with the draft spec (http://cwiki.apache.org/confluence/display/qpid/Management+Design+notes).
>> Per-file notes:
>> M  python/qpid/management.py
>> M  cpp/src/qpid/management/ManagementAgent.h
>> M  cpp/src/qpid/management/ManagementAgent.cpp
>> M  cpp/src/qpid/management/ManagementExchange.h
>> M  cpp/src/qpid/management/ManagementObject.h
>> M  specs/management-types.xml
>>    Added support for new management types.
>>    Updated protocol to comply with draft spec in the wiki.
>> M  python/mgmt-cli/main.py
>> M  python/mgmt-cli/managementdata.py
>>    Lots of enhanced CLI functionality
>> M  cpp/src/qpid/broker/Broker.h
>> M  cpp/src/qpid/broker/Broker.cpp
>>    Added method to get the VHost object, added call to shutdown the
>>    management agent when the broker is destroyed.
>> M  cpp/src/qpid/broker/Queue.cpp
>>    Removed IncreaseJournalSize method (not relevant to QPID)
>> M  cpp/src/qpid/broker/Connection.h
>> M  cpp/src/qpid/broker/Connection.cpp
>> M  cpp/src/qpid/broker/ConnectionFactory.h
>> M  cpp/src/qpid/broker/ConnectionFactory.cpp
>> M  cpp/src/qpid/sys/ConnectionInputHandlerFactory.h
>> M  cpp/src/qpid/sys/AsynchIOAcceptor.cpp
>>    Added management for Connections (Client management class).  The
>>    socket is now passed to the Connection object so access can be had
>>    to the remote IP-address and port.
>> M  cpp/src/qpid/broker/SessionState.cpp
>> M  cpp/src/qpid/broker/SessionManager.cpp
>> M  cpp/src/qpid/broker/SessionState.h
>>    Added management for SessionState (Session management class).
>> M  cpp/managementgen/main.py
>>    Makefile fragment generation is now optional.
>> M  specs/management-schema.xml
>>    Schema updates for Client and Session.
>>     
>
>   


[jira] Updated: (QPID-715) Management improvements for C++ Broker, Python API, and Python CLI

Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Ross updated QPID-715:
--------------------------

    Attachment: qpid-patch14.diff

patch file

> Management improvements for C++ Broker, Python API, and Python CLI
> ------------------------------------------------------------------
>
>                 Key: QPID-715
>                 URL: https://issues.apache.org/jira/browse/QPID-715
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker, Python Client
>         Environment: all
>            Reporter: Ted Ross
>            Priority: Minor
>         Attachments: qpid-patch14.diff
>
>
> This patch provides improvements in the management CLI and brings the implementation of the broker and the python management client into compliance with the draft spec (http://cwiki.apache.org/confluence/display/qpid/Management+Design+notes).
> Per-file notes:
> M  python/qpid/management.py
> M  cpp/src/qpid/management/ManagementAgent.h
> M  cpp/src/qpid/management/ManagementAgent.cpp
> M  cpp/src/qpid/management/ManagementExchange.h
> M  cpp/src/qpid/management/ManagementObject.h
> M  specs/management-types.xml
>    Added support for new management types.
>    Updated protocol to comply with draft spec in the wiki.
> M  python/mgmt-cli/main.py
> M  python/mgmt-cli/managementdata.py
>    Lots of enhanced CLI functionality
> M  cpp/src/qpid/broker/Broker.h
> M  cpp/src/qpid/broker/Broker.cpp
>    Added method to get the VHost object, added call to shutdown the
>    management agent when the broker is destroyed.
> M  cpp/src/qpid/broker/Queue.cpp
>    Removed IncreaseJournalSize method (not relevant to QPID)
> M  cpp/src/qpid/broker/Connection.h
> M  cpp/src/qpid/broker/Connection.cpp
> M  cpp/src/qpid/broker/ConnectionFactory.h
> M  cpp/src/qpid/broker/ConnectionFactory.cpp
> M  cpp/src/qpid/sys/ConnectionInputHandlerFactory.h
> M  cpp/src/qpid/sys/AsynchIOAcceptor.cpp
>    Added management for Connections (Client management class).  The
>    socket is now passed to the Connection object so access can be had
>    to the remote IP-address and port.
> M  cpp/src/qpid/broker/SessionState.cpp
> M  cpp/src/qpid/broker/SessionManager.cpp
> M  cpp/src/qpid/broker/SessionState.h
>    Added management for SessionState (Session management class).
> M  cpp/managementgen/main.py
>    Makefile fragment generation is now optional.
> M  specs/management-schema.xml
>    Schema updates for Client and Session.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.