You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Gus Heck (Jira)" <ji...@apache.org> on 2021/04/28 05:01:00 UTC
[jira] [Commented] (SOLR-15376) Update SolrJ
CollectionAdminRequest.CreateTimeRoutedAlias.setMaxFutureMs
[ https://issues.apache.org/jira/browse/SOLR-15376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334449#comment-17334449 ]
Gus Heck commented on SOLR-15376:
---------------------------------
Good catch, but changing to a string parameter would break backwards compatibility. On the other hand, overloading the method to also take a {{Long}} might work. Perhaps the Integer based method might be deprecated for removal in 9 as well...
It's pretty unlikely that Long isn't long enough :). I wouldn't take a string unless we were trying to do something like accept an arbitrary duration specifier (ISO 8601 or similar), but then that would also need to be available for the other API's as well so it's a much larger change that would want it's own Jira ticket...
> Update SolrJ CollectionAdminRequest.CreateTimeRoutedAlias.setMaxFutureMs
> ------------------------------------------------------------------------
>
> Key: SOLR-15376
> URL: https://issues.apache.org/jira/browse/SOLR-15376
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: clients - java
> Reporter: Nahian-Al Hasan
> Priority: Major
>
> `CollectionAdminRequest.CreateTimeRoutedAlias.setMaxFutureMs` method only accepts an integer value as a parameter. The Java Integer.MAX_VALUE is `2147483647`. This value is too small to accommodate for any duration greater than ~ 25 days.
> Solution:
> - Update the parameter to accept a String value for bigger a bigger duration. This is already possible via the `CollectionAdminRequest.SetAliasProperty` class.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org