You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "andreachild (via GitHub)" <gi...@apache.org> on 2025/11/13 00:20:18 UTC
[PR] Fix for JavaTranslator handling of has with null last argument [tinkerpop]
andreachild opened a new pull request, #3278:
URL: https://github.com/apache/tinkerpop/pull/3278
Fixed JavaTranslator to handle scenarios for has where the second or third arguments are null. If a null second or third argument is encountered, the method overload with a predicate type for the last arg should be avoided as a null predicate will throw NullPointerException.
This is the quick solution to @andrii0lomakin's open PR to address the same issue but will not be ready in time for the 3.8.0 release: https://github.com/apache/tinkerpop/pull/3274.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for JavaTranslator handling of has with null last argument [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3278:
URL: https://github.com/apache/tinkerpop/pull/3278#issuecomment-3524535464
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3278?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`3.8-dev@eeeb273`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.8-dev #3278 +/- ##
==========================================
Coverage ? 79.14%
==========================================
Files ? 28
Lines ? 5951
Branches ? 0
==========================================
Hits ? 4710
Misses ? 1020
Partials ? 221
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3278?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for JavaTranslator handling of has with null last argument [tinkerpop]
Posted by "andrii0lomakin (via GitHub)" <gi...@apache.org>.
andrii0lomakin commented on PR #3278:
URL: https://github.com/apache/tinkerpop/pull/3278#issuecomment-3526784387
Oh @andreachild, thank you, really appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for JavaTranslator handling of has with null last argument [tinkerpop]
Posted by "andrii0lomakin (via GitHub)" <gi...@apache.org>.
andrii0lomakin commented on PR #3278:
URL: https://github.com/apache/tinkerpop/pull/3278#issuecomment-3526829594
Though I think the observation written in the comment to the code that fixing the issue is incorrect, the problem is not in ByteCode per se, but how JavaTranslator handles it, simple sorting by tree inheritance will providea general solution, I will create new version with this approach but will reuse tests that you already created it will cover all similar bugs without need to keep an eye on how JavaTranslator calls them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for JavaTranslator handling of has with null last argument [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3278:
URL: https://github.com/apache/tinkerpop/pull/3278#issuecomment-3524633640
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for JavaTranslator handling of has with null last argument [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3278:
URL: https://github.com/apache/tinkerpop/pull/3278#issuecomment-3524507546
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for JavaTranslator handling of has with null last argument [tinkerpop]
Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild merged PR #3278:
URL: https://github.com/apache/tinkerpop/pull/3278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org