[jira] Commented: (DERBY-843) Internationalize messages in SectionManager to XaException in org.apache.derby.client.am

["Knut Anders Hatlen (JIRA)" <de...@db.apache.org>]

    [ http://issues.apache.org/jira/browse/DERBY-843?page=comments#action_12375084 ] 

Knut Anders Hatlen commented on DERBY-843:
------------------------------------------

Hi David,

I got a bit worried when you said "This patch went through a derbyall
run and I updated all the output files." Does this mean you ran
derbyall and just copied the out files from the failing tests?

I have read through your patch, and I have some questions:

The canons for lang/updatableResultSet.java have a lot of diffs like
this one:

   Test updateBlob on a readonly resultset
   Using column position as first parameter to updateBlob
-  Got expected exception : JDBC 3 method called - not yet supported
   Using column name as first parameter to updateBlob
-  Got expected exception : JDBC 3 method called - not yet supported

Could you explain why we shouldn't expect the exception any more?
Haven't you only changed the message?

The same canons also have this diff, which I don't understand:

 	{7,null}
 	{8,8}
+	{82,82}
 	 C51,C52
 	 --- ---

In jdbc4/StatementTest.java you have made this change:

+            assertEquals("Unexpected SQL state for performing " +
+                    "operations on a closed statement.",
+                    SQLState.NO_CURRENT_CONNECTION,
+                    sqle.getSQLState());

I think it was concluded in a recent thread that using constants from
SQLState.java should be avoided in the tests. Should we change this to
a hard-coded string?

> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
>          Key: DERBY-843
>          URL: http://issues.apache.org/jira/browse/DERBY-843
>      Project: Derby
>         Type: Sub-task

>   Components: Network Client
>     Reporter: David Van Couvering
>     Assignee: David Van Couvering
>  Attachments: DERBY-843-2.diff, DERBY-843.diff
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira