You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/22 10:20:03 UTC

[GitHub] [shardingsphere] lwclover opened a new pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

lwclover opened a new pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227


   Fixes #13213.
   
   Changes proposed in this pull request:
   -
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#discussion_r739975483



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/datasource/killer/impl/DefaultDataSourceKiller.java
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.config.datasource.killer.impl;
+
+import java.sql.SQLException;
+
+import javax.sql.DataSource;
+
+import org.apache.shardingsphere.infra.config.datasource.killer.DataSourceKiller;
+
+/**
+ * Kill hikari data source.

Review comment:
       Could you please check the javadoc again?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-949747309


   Hi @menghaoranss ,
   Can you help review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-950600296


   > Hi @menghaoranss ,
   > Can you help review this PR?
   
   @RaigorJiang thanks for reminding


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#discussion_r739084873



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/datasource/killer/impl/DefaultDataSourceKiller.java
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.config.datasource.killer.impl;
+
+import java.sql.SQLException;
+
+import javax.sql.DataSource;
+
+import org.apache.shardingsphere.infra.config.datasource.killer.DataSourceKiller;
+
+/**
+ * Close hikari data source.

Review comment:
       The javadoc is incorrect.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-949589524


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#13227](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb6c59f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3f6729997d64628ca65fa84ee7aa9cf22fedaee4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f67299) will **decrease** coverage by `0.01%`.
   > The diff coverage is `48.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/13227/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #13227      +/-   ##
   ============================================
   - Coverage     62.98%   62.96%   -0.02%     
   - Complexity     1399     1402       +3     
   ============================================
     Files          2558     2559       +1     
     Lines         38268    38329      +61     
     Branches       6577     6582       +5     
   ============================================
   + Hits          24102    24135      +33     
   - Misses        12273    12300      +27     
   - Partials       1893     1894       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...datasource/closer/impl/HikariDataSourceCloser.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9jbG9zZXIvaW1wbC9IaWthcmlEYXRhU291cmNlQ2xvc2VyLmphdmE=) | `14.28% <14.28%> (ø)` | |
   | [...fig/datasource/closer/DataSourceCloserFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9jbG9zZXIvRGF0YVNvdXJjZUNsb3NlckZhY3RvcnkuamF2YQ==) | `75.00% <75.00%> (ø)` | |
   | [...atasource/closer/impl/DefaultDataSourceCloser.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9jbG9zZXIvaW1wbC9EZWZhdWx0RGF0YVNvdXJjZUNsb3Nlci5qYXZh) | `77.77% <77.77%> (ø)` | |
   | [...nfra/metadata/resource/ShardingSphereResource.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZXNvdXJjZS9TaGFyZGluZ1NwaGVyZVJlc291cmNlLmphdmE=) | `77.77% <100.00%> (+11.11%)` | :arrow_up: |
   | [...ptimize/converter/segment/from/TableConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2Zyb20vVGFibGVDb252ZXJ0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ze/converter/segment/groupby/GroupByConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2dyb3VwYnkvR3JvdXBCeUNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../converter/statement/SelectStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zdGF0ZW1lbnQvU2VsZWN0U3RhdGVtZW50Q29udmVydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...onverter/segment/from/impl/JoinTableConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2Zyb20vaW1wbC9Kb2luVGFibGVDb252ZXJ0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...verter/segment/from/impl/SimpleTableConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2Zyb20vaW1wbC9TaW1wbGVUYWJsZUNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ter/segment/limit/PaginationValueSQLConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2xpbWl0L1BhZ2luYXRpb25WYWx1ZVNRTENvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [12 more](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f67299...fb6c59f](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#discussion_r739084315



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/datasource/killer/DataSourceKillerFactory.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.config.datasource.killer;
+
+import org.apache.shardingsphere.spi.ShardingSphereServiceLoader;
+import org.apache.shardingsphere.spi.required.RequiredSPIRegistry;
+import org.apache.shardingsphere.spi.typed.TypedSPIRegistry;
+
+import java.util.Properties;
+
+/**
+ * Data source closer factory.
+ */
+public final class DataSourceKillerFactory {
+    
+    static {
+        ShardingSphereServiceLoader.register(DataSourceKiller.class);
+    }
+    
+    /**
+     * Get data source closer.
+     * 
+     * @param dataSourceClassName data source class name
+     * @return data source closer

Review comment:
       The naming in javadoc are outdated too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-949589524


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#13227](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c8fcae) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6f92a527a1b0259a4815dd364de628c4495c7df0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f92a52) will **increase** coverage by `0.42%`.
   > The diff coverage is `48.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/13227/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #13227      +/-   ##
   ============================================
   + Coverage     62.87%   63.29%   +0.42%     
   - Complexity     1401     1432      +31     
   ============================================
     Files          2566     2668     +102     
     Lines         38402    39763    +1361     
     Branches       6603     6833     +230     
   ============================================
   + Hits          24145    25169    +1024     
   - Misses        12363    12662     +299     
   - Partials       1894     1932      +38     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...datasource/killer/impl/HikariDataSourceKiller.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9raWxsZXIvaW1wbC9IaWthcmlEYXRhU291cmNlS2lsbGVyLmphdmE=) | `14.28% <14.28%> (ø)` | |
   | [...fig/datasource/killer/DataSourceKillerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9raWxsZXIvRGF0YVNvdXJjZUtpbGxlckZhY3RvcnkuamF2YQ==) | `75.00% <75.00%> (ø)` | |
   | [...atasource/killer/impl/DefaultDataSourceKiller.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9raWxsZXIvaW1wbC9EZWZhdWx0RGF0YVNvdXJjZUtpbGxlci5qYXZh) | `77.77% <77.77%> (ø)` | |
   | [...nfra/metadata/resource/ShardingSphereResource.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZXNvdXJjZS9TaGFyZGluZ1NwaGVyZVJlc291cmNlLmphdmE=) | `77.77% <100.00%> (+11.11%)` | :arrow_up: |
   | [...ropShardingBroadcastTableRulesStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yZGwvZHJvcC9pbXBsL0Ryb3BTaGFyZGluZ0Jyb2FkY2FzdFRhYmxlUnVsZXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [...alect/handler/ddl/CreateTableStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RkbC9DcmVhdGVUYWJsZVN0YXRlbWVudEhhbmRsZXIuamF2YQ==) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | [...dialect/handler/ddl/DropTableStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RkbC9Ecm9wVGFibGVTdGF0ZW1lbnRIYW5kbGVyLmphdmE=) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
   | [.../infra/rule/builder/schema/SchemaRulesBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9ydWxlL2J1aWxkZXIvc2NoZW1hL1NjaGVtYVJ1bGVzQnVpbGRlci5qYXZh) | `65.71% <0.00%> (-19.48%)` | :arrow_down: |
   | [...distsql/rdl/rule/RuleDefinitionBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL3J1bGUvUnVsZURlZmluaXRpb25CYWNrZW5kSGFuZGxlci5qYXZh) | `64.81% <0.00%> (-17.69%)` | :arrow_down: |
   | [.../select/projection/impl/AggregationProjection.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9pbXBsL0FnZ3JlZ2F0aW9uUHJvamVjdGlvbi5qYXZh) | `50.00% <0.00%> (-16.67%)` | :arrow_down: |
   | ... and [245 more](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6f92a52...5c8fcae](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#discussion_r738963003



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/datasource/killer/DataSourceKillerFactory.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.config.datasource.killer;
+
+import org.apache.shardingsphere.spi.ShardingSphereServiceLoader;
+import org.apache.shardingsphere.spi.required.RequiredSPIRegistry;
+import org.apache.shardingsphere.spi.typed.TypedSPIRegistry;
+
+import java.util.Properties;
+
+/**
+ * Data source closer factory.
+ */
+public final class DataSourceKillerFactory {
+    
+    static {
+        ShardingSphereServiceLoader.register(DataSourceKiller.class);
+    }
+    
+    /**
+     * Get data source closer.
+     * 
+     * @param dataSourceClassName data source class name
+     * @return data source closer
+     */
+    public static DataSourceKiller getDataSourceCloser(final String dataSourceClassName) {

Review comment:
       `Killer` or `Closer`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#discussion_r735062759



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/resources/META-INF/services/org.apache.shardingsphere.infra.config.datasource.closer.DataSourceCloser
##########
@@ -0,0 +1,19 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+org.apache.shardingsphere.infra.config.datasource.closer.impl.DefaultDataSourceCloser
+org.apache.shardingsphere.infra.config.datasource.closer.impl.HikariDataSourceCloser

Review comment:
       Hi @lwclover This PR smell and style is great. You definitely dove into the source code of ShardingSphere, didn't you? Nice!
   Plus, could you consider the comments below?
   1. Please append a new line to the bottom of this class.
   2. `Closer`...sounds a little unclear. How about `Killer`, `Ternimator` or `Manger`?
   
   @menghaoranss Please double check here. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lwclover commented on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
lwclover commented on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-953715648


   > @lwclover Please check this failed CI, thank you.
   > 
   > ![image](https://user-images.githubusercontent.com/5668787/138806541-f4622d46-0cb3-470d-9a86-e262d74e43f6.png)
   
   I will do it later,I've been a little busy these last few days


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-949589524


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#13227](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dff93b5) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6f92a527a1b0259a4815dd364de628c4495c7df0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f92a52) will **increase** coverage by `0.17%`.
   > The diff coverage is `48.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/13227/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #13227      +/-   ##
   ============================================
   + Coverage     62.87%   63.04%   +0.17%     
   - Complexity     1401     1451      +50     
   ============================================
     Files          2566     2582      +16     
     Lines         38402    38622     +220     
     Branches       6603     6625      +22     
   ============================================
   + Hits          24145    24350     +205     
   - Misses        12363    12382      +19     
   + Partials       1894     1890       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...datasource/killer/impl/HikariDataSourceKiller.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9raWxsZXIvaW1wbC9IaWthcmlEYXRhU291cmNlS2lsbGVyLmphdmE=) | `14.28% <14.28%> (ø)` | |
   | [...fig/datasource/killer/DataSourceKillerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9raWxsZXIvRGF0YVNvdXJjZUtpbGxlckZhY3RvcnkuamF2YQ==) | `75.00% <75.00%> (ø)` | |
   | [...atasource/killer/impl/DefaultDataSourceKiller.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZGF0YXNvdXJjZS9raWxsZXIvaW1wbC9EZWZhdWx0RGF0YVNvdXJjZUtpbGxlci5qYXZh) | `77.77% <77.77%> (ø)` | |
   | [...nfra/metadata/resource/ShardingSphereResource.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZXNvdXJjZS9TaGFyZGluZ1NwaGVyZVJlc291cmNlLmphdmE=) | `77.77% <100.00%> (+11.11%)` | :arrow_up: |
   | [...ropShardingBroadcastTableRulesStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yZGwvZHJvcC9pbXBsL0Ryb3BTaGFyZGluZ0Jyb2FkY2FzdFRhYmxlUnVsZXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [...a/binder/statement/dml/DeleteStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RtbC9EZWxldGVTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `94.44% <0.00%> (-5.56%)` | :arrow_down: |
   | [...persist/service/impl/SchemaRulePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2ltcGwvU2NoZW1hUnVsZVBlcnNpc3RTZXJ2aWNlLmphdmE=) | `25.00% <0.00%> (-5.00%)` | :arrow_down: |
   | [.../text/admin/mysql/executor/ShowTablesExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL215c3FsL2V4ZWN1dG9yL1Nob3dUYWJsZXNFeGVjdXRvci5qYXZh) | `45.00% <0.00%> (-5.00%)` | :arrow_down: |
   | [...ra/config/properties/ConfigurationPropertyKey.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvcHJvcGVydGllcy9Db25maWd1cmF0aW9uUHJvcGVydHlLZXkuamF2YQ==) | `95.23% <0.00%> (-4.77%)` | :arrow_down: |
   | [...ngsphere/scaling/core/api/impl/ScalingAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9hcGkvaW1wbC9TY2FsaW5nQVBJSW1wbC5qYXZh) | `71.21% <0.00%> (-4.23%)` | :arrow_down: |
   | ... and [87 more](https://codecov.io/gh/apache/shardingsphere/pull/13227/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6f92a52...dff93b5](https://codecov.io/gh/apache/shardingsphere/pull/13227?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-956146538


   @lwclover @menghaoranss @TeslaCN Cool, guys.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#discussion_r736457418



##########
File path: shardingsphere-infra/shardingsphere-infra-common/pom.xml
##########
@@ -69,6 +69,7 @@
         <dependency>
             <groupId>com.zaxxer</groupId>
             <artifactId>HikariCP</artifactId>
+            <scope>compile</scope>

Review comment:
       HikariCP is an option of DataSource for ShardingSphere JDBC. If the scope changed to `compile`, the HikariCP will be introduced into ShardingSphere JDBC by default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-951536215


   @lwclover 
   Please check this failed CI, thank you.
   
   ![image](https://user-images.githubusercontent.com/5668787/138806541-f4622d46-0cb3-470d-9a86-e262d74e43f6.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lwclover removed a comment on pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
lwclover removed a comment on pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227#issuecomment-953715648


   > @lwclover Please check this failed CI, thank you.
   > 
   > ![image](https://user-images.githubusercontent.com/5668787/138806541-f4622d46-0cb3-470d-9a86-e262d74e43f6.png)
   
   I will do it later,I've been a little busy these last few days


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #13227: Exception occurs when Changing /meta/scheamName/dataSources/ config in registry.

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #13227:
URL: https://github.com/apache/shardingsphere/pull/13227


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org