You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/11/26 18:38:02 UTC
Review Request 40756: Updated allocator to use `nonRevocable()` where
appropriate.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Bugs: MESOS-4020
https://issues.apache.org/jira/browse/MESOS-4020
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
Diff: https://reviews.apache.org/r/40756/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40756: Updated codebase to use `nonRevocable()`
where appropriate.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 27, 2015, 12:54 a.m., Guangya Liu wrote:
> > I think we should also update https://github.com/apache/mesos/blob/master/src/common/http.cpp#L94
>
> Guangya Liu wrote:
> It is ok if only want to handle allocator part.
Yeah, we can extend the scope of the update.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/#review108177
-----------------------------------------------------------
On Nov. 27, 2015, 2:48 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40756/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 2:48 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4020
> https://issues.apache.org/jira/browse/MESOS-4020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/http.cpp 692ea3fba2e48e8f8b5257a6bb6ea8a40609013b
> src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
> src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745
> src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c
>
> Diff: https://reviews.apache.org/r/40756/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40756: Updated allocator to use `nonRevocable()`
where appropriate.
Posted by Guangya Liu <gy...@gmail.com>.
> On 十一月 27, 2015, 12:54 a.m., Guangya Liu wrote:
> > I think we should also update https://github.com/apache/mesos/blob/master/src/common/http.cpp#L94
It is ok if only want to handle allocator part.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/#review108177
-----------------------------------------------------------
On 十一月 26, 2015, 5:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40756/
> -----------------------------------------------------------
>
> (Updated 十一月 26, 2015, 5:38 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4020
> https://issues.apache.org/jira/browse/MESOS-4020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
>
> Diff: https://reviews.apache.org/r/40756/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40756: Updated allocator to use `nonRevocable()`
where appropriate.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/#review108177
-----------------------------------------------------------
I think we should also update https://github.com/apache/mesos/blob/master/src/common/http.cpp#L94
- Guangya Liu
On 十一月 26, 2015, 5:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40756/
> -----------------------------------------------------------
>
> (Updated 十一月 26, 2015, 5:38 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4020
> https://issues.apache.org/jira/browse/MESOS-4020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
>
> Diff: https://reviews.apache.org/r/40756/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40756: Updated codebase to use `nonRevocable()`
where appropriate.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/
-----------------------------------------------------------
(Updated Nov. 27, 2015, 2:48 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Apply `nonRevocable()` filter more widely.
Summary (updated)
-----------------
Updated codebase to use `nonRevocable()` where appropriate.
Bugs: MESOS-4020
https://issues.apache.org/jira/browse/MESOS-4020
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/common/http.cpp 692ea3fba2e48e8f8b5257a6bb6ea8a40609013b
src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745
src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c
Diff: https://reviews.apache.org/r/40756/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40756: Updated allocator to use `nonRevocable()`
where appropriate.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/#review108173
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40755, 40756]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 26, 2015, 5:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40756/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 5:38 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4020
> https://issues.apache.org/jira/browse/MESOS-4020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
>
> Diff: https://reviews.apache.org/r/40756/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40756: Updated allocator to use `nonRevocable()`
where appropriate.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/#review108175
-----------------------------------------------------------
Ship it!
Ship It!
- Klaus Ma
On Nov. 27, 2015, 1:38 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40756/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 1:38 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4020
> https://issues.apache.org/jira/browse/MESOS-4020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
>
> Diff: https://reviews.apache.org/r/40756/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>